Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump example image versions #3138

Merged
merged 1 commit into from
May 5, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion build/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ KIND_PROFILE ?= agones
KIND_CONTAINER_NAME=$(KIND_PROFILE)-control-plane

# Game Server image to use while doing end-to-end tests
GS_TEST_IMAGE ?= us-docker.pkg.dev/agones-images/examples/simple-game-server:0.15
GS_TEST_IMAGE ?= us-docker.pkg.dev/agones-images/examples/simple-game-server:0.16

# Enable all alpha feature gates. Keep in sync with `false` (alpha) entries in pkg/util/runtime/features.go:featureDefaults
ALPHA_FEATURE_GATES ?= "PlayerAllocationFilter=true&PlayerTracking=true&ResetMetricsOnDelete=true&SplitControllerAndExtensions=true&CountsAndLists=true&FleetAllocationOverflow=true&Example=true"
Expand Down
46 changes: 44 additions & 2 deletions build/includes/examples.mk
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
# |_|\__,_|_| \__, |\___|\__|___/
# |___/

# test all example images exist on Google Artifact Registry
# test all example images exist on Google Artifact Registry (GAR)
test-examples-on-gar: example-image-test.allocation-endpoint
test-examples-on-gar: example-image-test.autoscaler-webhook
test-examples-on-gar: example-image-test.cpp-simple
Expand All @@ -38,8 +38,9 @@ test-examples-on-gar: example-image-test.simple-game-server
push-example-golang-images: example-image-push.allocation-endpoint
push-example-golang-images: example-image-push.autoscaler-webhook
push-example-golang-images: example-image-push.crd-client
push-example-golang-images: example-image-push.supertuxkart
push-example-golang-images: example-image-push.simple-game-server
push-example-golang-images: example-image-push.supertuxkart
push-example-golang-images: example-image-push.xonotic

# Test to ensure the example image found in the % folder is on GAR. Fails if it is not.
example-image-test.%:
Expand All @@ -48,3 +49,44 @@ example-image-test.%:
example-image-push.%:
$(DOCKER_RUN) bash -c "cd examples/$* && make push"

# Perform make build for golang examples
build-go-examples: build-example-allocation-endpoint build-example-autoscaler-webhook build-example-crd-client build-example-simple-game-server build-example-supertuxkart build-example-xonotic

# Perform make build for all examples
build-examples: build-example-allocation-endpoint build-example-autoscaler-webhook build-example-cpp-simple build-example-crd-client build-example-nodejs-simple build-example-rust-simple build-example-simple-game-server build-example-supertuxkart build-example-xonotic

# Run "make build" command for one example directory
build-example:
cd $(examples_folder)/$(EXAMPLE); \
if [ -f Makefile ] ; then \
make build; \
else \
echo "Makefile was not found in "/examples/$(EXAMPLE)" directory - nothing to execute" ; \
fi

build-example-allocation-endpoint:
$(MAKE) build-example EXAMPLE=allocation-endpoint

build-example-autoscaler-webhook:
$(MAKE) build-example EXAMPLE=autoscaler-webhook

build-example-cpp-simple:
$(MAKE) build-example EXAMPLE=cpp-simple

build-example-crd-client:
$(MAKE) build-example EXAMPLE=crd-client

build-example-nodejs-simple:
$(MAKE) build-example EXAMPLE=nodejs-simple

build-example-rust-simple:
$(MAKE) build-example EXAMPLE=rust-simple

build-example-simple-game-server:
$(MAKE) build-example EXAMPLE=simple-game-server

build-example-supertuxkart:
$(MAKE) build-example EXAMPLE=supertuxkart

build-example-xonotic:
$(MAKE) build-example EXAMPLE=xonotic
27 changes: 0 additions & 27 deletions build/includes/sdk.mk
Original file line number Diff line number Diff line change
Expand Up @@ -213,30 +213,3 @@ sdk-shell-csharp:
sdk-publish-csharp: RELEASE_VERSION ?= $(base_version)
sdk-publish-csharp:
$(MAKE) run-sdk-command-csharp COMMAND=publish VERSION=$(RELEASE_VERSION) DOCKER_RUN_ARGS="$(DOCKER_RUN_ARGS) -it"

# Perform make build for all examples
build-examples: build-example-xonotic build-example-cpp-simple build-example-autoscaler-webhook build-example-nodejs-simple

# Run "make build" command for one example directory
build-example:
cd $(examples_folder)/$(EXAMPLE); \
if [ -f Makefile ] ; then \
make build; \
else \
echo "Makefile was not found in "/examples/$(EXAMPLE)" directory - nothing to execute" ; \
fi

build-example-xonotic:
$(MAKE) build-example EXAMPLE=xonotic

build-example-cpp-simple:
$(MAKE) build-example EXAMPLE=cpp-simple

build-example-rust-simple:
$(MAKE) build-example EXAMPLE=rust-simple

build-example-autoscaler-webhook:
$(MAKE) build-example EXAMPLE=autoscaler-webhook

build-example-nodejs-simple:
$(MAKE) build-example EXAMPLE=nodejs-simple
2 changes: 1 addition & 1 deletion examples/allocation-endpoint/terraform/variable.tf
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ variable "project_id" {
variable "ae_proxy_image" {
type = string
description = "The docker image of the allocation proxy."
default = "us-docker.pkg.dev/agones-images/examples/allocation-endpoint-proxy:0.4"
default = "us-docker.pkg.dev/agones-images/examples/allocation-endpoint-proxy:0.5"
}

variable "region" {
Expand Down
4 changes: 2 additions & 2 deletions examples/autoscaler-webhook/autoscaler-service-tls.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ spec:
- port: 8000
protocol: TCP
name: https
targetPort: autoscaler
targetPort: autoscaler
---
# Deploy a pod to run the autoscaler-webhook code
apiVersion: apps/v1
Expand All @@ -54,7 +54,7 @@ spec:
secretName: autoscalersecret
containers:
- name: autoscaler-webhook
image: us-docker.pkg.dev/agones-images/examples/autoscaler-webhook:0.5
image: us-docker.pkg.dev/agones-images/examples/autoscaler-webhook:0.6
imagePullPolicy: Always
volumeMounts:
- mountPath: /home/service/certs
Expand Down
4 changes: 2 additions & 2 deletions examples/autoscaler-webhook/autoscaler-service.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ spec:
- port: 8000
protocol: TCP
name: https
targetPort: autoscaler
targetPort: autoscaler
---
# Deploy a pod to run the autoscaler-webhook code
apiVersion: apps/v1
Expand All @@ -50,7 +50,7 @@ spec:
#serviceAccount: autoscaler-webhook
containers:
- name: autoscaler-webhook
image: us-docker.pkg.dev/agones-images/examples/autoscaler-webhook:0.5
image: us-docker.pkg.dev/agones-images/examples/autoscaler-webhook:0.6
imagePullPolicy: Always
ports:
- name: autoscaler
Expand Down
4 changes: 2 additions & 2 deletions examples/crd-client/create-gs.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -34,9 +34,9 @@ spec:
cpu: 500m
ephemeral-storage: 1Gi
memory: 2Gi
image: us-docker.pkg.dev/agones-images/examples/crd-client:0.8
image: us-docker.pkg.dev/agones-images/examples/crd-client:0.9
imagePullPolicy: Always
env:
- name: GAMESERVER_IMAGE
value: "us-docker.pkg.dev/agones-images/examples/simple-game-server:0.15"
value: "us-docker.pkg.dev/agones-images/examples/simple-game-server:0.16"
restartPolicy: Never
2 changes: 1 addition & 1 deletion examples/fleet.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -87,4 +87,4 @@ spec:
spec:
containers:
- name: simple-game-server
image: us-docker.pkg.dev/agones-images/examples/simple-game-server:0.15
image: us-docker.pkg.dev/agones-images/examples/simple-game-server:0.16
2 changes: 1 addition & 1 deletion examples/gameserver.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ spec:
spec:
containers:
- name: simple-game-server
image: us-docker.pkg.dev/agones-images/examples/simple-game-server:0.15
image: us-docker.pkg.dev/agones-images/examples/simple-game-server:0.16
imagePullPolicy: Always
# nodeSelector is a label that can be used to tell Kubernetes which host
# OS to use. For Windows game servers uncomment the nodeSelector
Expand Down
2 changes: 1 addition & 1 deletion examples/simple-game-server/dev-gameserver.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -31,4 +31,4 @@ spec:
spec:
containers:
- name: simple-game-server
image: us-docker.pkg.dev/agones-images/examples/simple-game-server:0.15
image: us-docker.pkg.dev/agones-images/examples/simple-game-server:0.16
2 changes: 1 addition & 1 deletion examples/simple-game-server/fleet-distributed.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ spec:
spec:
containers:
- name: simple-game-server
image: us-docker.pkg.dev/agones-images/examples/simple-game-server:0.15
image: us-docker.pkg.dev/agones-images/examples/simple-game-server:0.16
resources:
requests:
memory: "64Mi"
Expand Down
2 changes: 1 addition & 1 deletion examples/simple-game-server/fleet-tcp.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ spec:
spec:
containers:
- name: simple-game-server
image: us-docker.pkg.dev/agones-images/examples/simple-game-server:0.15
image: us-docker.pkg.dev/agones-images/examples/simple-game-server:0.16
env:
# Disables the UDP listener (Enabled by default)
- name: "UDP"
Expand Down
2 changes: 1 addition & 1 deletion examples/simple-game-server/fleet.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ spec:
spec:
containers:
- name: simple-game-server
image: us-docker.pkg.dev/agones-images/examples/simple-game-server:0.15
image: us-docker.pkg.dev/agones-images/examples/simple-game-server:0.16
resources:
requests:
memory: "64Mi"
Expand Down
2 changes: 1 addition & 1 deletion examples/simple-game-server/gameserver-passthrough.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ spec:
spec:
containers:
- name: simple-game-server
image: us-docker.pkg.dev/agones-images/examples/simple-game-server:0.15
image: us-docker.pkg.dev/agones-images/examples/simple-game-server:0.16
env:
- name: "PASSTHROUGH"
value: "TRUE"
Expand Down
2 changes: 1 addition & 1 deletion examples/simple-game-server/gameserver-windows.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ spec:
spec:
containers:
- name: simple-game-server
image: us-docker.pkg.dev/agones-images/examples/simple-game-server:0.15
image: us-docker.pkg.dev/agones-images/examples/simple-game-server:0.16
resources:
requests:
memory: "64Mi"
Expand Down
2 changes: 1 addition & 1 deletion examples/simple-game-server/gameserver.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ spec:
spec:
containers:
- name: simple-game-server
image: us-docker.pkg.dev/agones-images/examples/simple-game-server:0.15
image: us-docker.pkg.dev/agones-images/examples/simple-game-server:0.16
resources:
requests:
memory: "64Mi"
Expand Down
2 changes: 1 addition & 1 deletion examples/supertuxkart/fleet.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -32,4 +32,4 @@ spec:
spec:
containers:
- name: supertuxkart
image: us-docker.pkg.dev/agones-images/examples/supertuxkart-example:0.7
image: us-docker.pkg.dev/agones-images/examples/supertuxkart-example:0.8
2 changes: 1 addition & 1 deletion examples/supertuxkart/gameserver.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ spec:
spec:
containers:
- name: supertuxkart
image: us-docker.pkg.dev/agones-images/examples/supertuxkart-example:0.7
image: us-docker.pkg.dev/agones-images/examples/supertuxkart-example:0.8
# imagePullPolicy: Always # add for development
env:
- name: ENABLE_PLAYER_TRACKING
Expand Down
2 changes: 1 addition & 1 deletion examples/xonotic/fleet.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -35,4 +35,4 @@ spec:
spec:
containers:
- name: xonotic
image: us-docker.pkg.dev/agones-images/examples/xonotic-example:1.0
image: us-docker.pkg.dev/agones-images/examples/xonotic-example:1.1
4 changes: 2 additions & 2 deletions install/helm/agones/templates/tests/test-runner.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -25,11 +25,11 @@ spec:
serviceAccountName: agones-controller
containers:
- name: create-gameserver
image: us-docker.pkg.dev/agones-images/examples/crd-client:0.7
image: us-docker.pkg.dev/agones-images/examples/crd-client:0.9
imagePullPolicy: Always
env:
- name: GAMESERVER_IMAGE
value: "us-docker.pkg.dev/agones-images/examples/simple-game-server:0.15"
value: "us-docker.pkg.dev/agones-images/examples/simple-game-server:0.16"
- name: IS_HELM_TEST
value: "true"
- name: GAMESERVERS_NAMESPACE
Expand Down
2 changes: 1 addition & 1 deletion pkg/util/webhooks/webhooks_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,7 @@ func TestWebHookFleetValidationHandler(t *testing.T) {
"template": {
"spec": {
"containers": [{
"image": "us-docker.pkg.dev/agones-images/examples/simple-game-server:0.15",
"image": "us-docker.pkg.dev/agones-images/examples/simple-game-server:0.16",
"name": false
}]
}
Expand Down
2 changes: 1 addition & 1 deletion site/config.toml
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ dev_eks_example_cluster_version = "1.25"
dev_minikube_example_cluster_version = "1.25.7"

# example tag
example_image_tag = "us-docker.pkg.dev/agones-images/examples/simple-game-server:0.15"
example_image_tag = "us-docker.pkg.dev/agones-images/examples/simple-game-server:0.16"

# Enable syntax highlighting and copy buttons on code blocks with Prism
prism_syntax_highlighting = true
Expand Down
2 changes: 1 addition & 1 deletion test/e2e/fleetautoscaler_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -717,7 +717,7 @@ func defaultAutoscalerWebhook(namespace string) (*corev1.Pod, *corev1.Service) {
},
Spec: corev1.PodSpec{
Containers: []corev1.Container{{Name: "webhook",
Image: "us-docker.pkg.dev/agones-images/examples/autoscaler-webhook:0.5",
Image: "us-docker.pkg.dev/agones-images/examples/autoscaler-webhook:0.6",
ImagePullPolicy: corev1.PullAlways,
Ports: []corev1.ContainerPort{{
ContainerPort: 8000,
Expand Down
2 changes: 1 addition & 1 deletion test/e2e/framework/framework.go
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ func NewFromFlags() (*Framework, error) {
}

viper.SetDefault(kubeconfigFlag, filepath.Join(usr.HomeDir, ".kube", "config"))
viper.SetDefault(gsimageFlag, "us-docker.pkg.dev/agones-images/examples/simple-game-server:0.15")
viper.SetDefault(gsimageFlag, "us-docker.pkg.dev/agones-images/examples/simple-game-server:0.16")
viper.SetDefault(pullSecretFlag, "")
viper.SetDefault(stressTestLevelFlag, 0)
viper.SetDefault(perfOutputDirFlag, "")
Expand Down
2 changes: 1 addition & 1 deletion test/e2e/gameserver_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -982,7 +982,7 @@ spec:
preferredDuringSchedulingIgnoredDuringExecution: ERROR
containers:
- name: simple-game-server
image: us-docker.pkg.dev/agones-images/examples/simple-game-server:0.15
image: us-docker.pkg.dev/agones-images/examples/simple-game-server:0.16
`
err := os.WriteFile("/tmp/invalid.yaml", []byte(gsYaml), 0o644)
require.NoError(t, err)
Expand Down
2 changes: 1 addition & 1 deletion test/load/allocation/fleet.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ spec:
- args:
# We setup the simple-game-server server to shutdown 10 mins after allocation
- -automaticShutdownDelaySec=600
image: us-docker.pkg.dev/agones-images/examples/simple-game-server:0.15
image: us-docker.pkg.dev/agones-images/examples/simple-game-server:0.16
name: simple-game-server
resources:
limits:
Expand Down
2 changes: 1 addition & 1 deletion test/load/allocation/scenario-fleet.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ spec:
value: 'true'
containers:
- name: simple-game-server
image: us-docker.pkg.dev/agones-images/examples/simple-game-server:0.15
image: us-docker.pkg.dev/agones-images/examples/simple-game-server:0.16
args:
- -automaticShutdownDelaySec=60
- -readyIterations=10
Expand Down