Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump example image versions #3138

Merged
merged 1 commit into from
May 5, 2023
Merged

Conversation

igooch
Copy link
Collaborator

@igooch igooch commented May 5, 2023

What type of PR is this?

/kind cleanup

What this PR does / Why we need it:

Continues #3137 upgrading to Golang 1.20.4 by bumping up the example version numbers.
Also moves build example commands from the SDK Makefile to the Example Makefile.

Which issue(s) this PR fixes:

N/A

Special notes for your reviewer:

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 836f40ad-5375-43af-91b1-9e0aaf5d3248

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 2bf1739b-8087-4b67-83de-20bced009418

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: cf689cd5-cb2c-4985-8378-ca052d0b8c93

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 6adea12e-cf26-4596-a931-5cf1c869b788

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3138/head:pr_3138 && git checkout pr_3138
  • helm install agones ./install/helm/agones --namespace agones-system --agones.image.release=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.32.0-3360ac9-amd64

@google-oss-prow google-oss-prow bot added the lgtm label May 5, 2023
@gongmax gongmax merged commit f6ebced into googleforgames:main May 5, 2023
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: gongmax, igooch
Once this PR has been reviewed and has the lgtm label, please assign ericfortin for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@igooch igooch deleted the upgrade-golang-1.20 branch May 11, 2023 19:47
@Kalaiselvi84 Kalaiselvi84 added the kind/cleanup Refactoring code, fixing up documentation, etc label May 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Refactoring code, fixing up documentation, etc lgtm size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants