Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

require.NoError in fleet tests instead of continuing #3124

Merged
merged 2 commits into from
Apr 24, 2023
Merged

require.NoError in fleet tests instead of continuing #3124

merged 2 commits into from
Apr 24, 2023

Commits on Apr 24, 2023

  1. require.NoError in fleet tests instead of continuing 

    When the fleet tests flake, they take out the rest of the test suite:

```
Step googleforgames#24 - "submit-e2e-test-cloud-build": gke-autopilot-1.24: Step googleforgames#2 - "e2e-stable": VERBOSE: --- FAIL: TestFleetScaleUpAllocateEditAndScaleDownToZero (163.39s)
Step googleforgames#24 - "submit-e2e-test-cloud-build": gke-autopilot-1.24: Step googleforgames#2 - "e2e-stable": VERBOSE: panic: runtime error: index out of range [0] with length 0 [recovered]
Step googleforgames#24 - "submit-e2e-test-cloud-build": gke-autopilot-1.24: Step googleforgames#2 - "e2e-stable": VERBOSE:     panic: runtime error: index out of range [0] with length 0
```

Looking at this file, it's easy to see why: if there's every an error
from any of these asserts, we just continue with the test and assume
the fleet is valid. But it's not.
    @zmerlynn
    zmerlynn committed Apr 24, 2023
    Configuration menu
    Copy the full SHA
    376523a View commit details
    Browse the repository at this point in the history

  2. Also make logging resilient to 0 gameservers

    @zmerlynn
    zmerlynn committed Apr 24, 2023
    Configuration menu
    Copy the full SHA
    0ebd4f5 View commit details
    Browse the repository at this point in the history