Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

require.NoError in fleet tests instead of continuing #3124

Merged
merged 2 commits into from
Apr 24, 2023

Conversation

zmerlynn
Copy link
Collaborator

When the fleet tests flake, they take out the rest of the test suite:

Step #24 - "submit-e2e-test-cloud-build": gke-autopilot-1.24: Step #2 - "e2e-stable": VERBOSE: --- FAIL: TestFleetScaleUpAllocateEditAndScaleDownToZero (163.39s)
Step #24 - "submit-e2e-test-cloud-build": gke-autopilot-1.24: Step #2 - "e2e-stable": VERBOSE: panic: runtime error: index out of range [0] with length 0 [recovered]
Step #24 - "submit-e2e-test-cloud-build": gke-autopilot-1.24: Step #2 - "e2e-stable": VERBOSE:     panic: runtime error: index out of range [0] with length 0

When the fleet tests flake, they take out the rest of the test suite:

```
Step googleforgames#24 - "submit-e2e-test-cloud-build": gke-autopilot-1.24: Step googleforgames#2 - "e2e-stable": VERBOSE: --- FAIL: TestFleetScaleUpAllocateEditAndScaleDownToZero (163.39s)
Step googleforgames#24 - "submit-e2e-test-cloud-build": gke-autopilot-1.24: Step googleforgames#2 - "e2e-stable": VERBOSE: panic: runtime error: index out of range [0] with length 0 [recovered]
Step googleforgames#24 - "submit-e2e-test-cloud-build": gke-autopilot-1.24: Step googleforgames#2 - "e2e-stable": VERBOSE:     panic: runtime error: index out of range [0] with length 0
```

Looking at this file, it's easy to see why: if there's every an error
from any of these asserts, we just continue with the test and assume
the fleet is valid. But it's not.
@google-oss-prow google-oss-prow bot added the lgtm label Apr 24, 2023
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: gongmax, zmerlynn
Once this PR has been reviewed and has the lgtm label, please assign markmandel for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 5d8cd35e-9ce3-4ea0-89bc-d0a41869054b

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@google-oss-prow google-oss-prow bot removed the lgtm label Apr 24, 2023
@google-oss-prow
Copy link

New changes are detected. LGTM label has been removed.

@zmerlynn zmerlynn enabled auto-merge (squash) April 24, 2023 23:27
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 36320fa6-5385-4535-99de-9a438ef5a4a6

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3124/head:pr_3124 && git checkout pr_3124
  • helm install agones ./install/helm/agones --namespace agones-system --agones.image.release=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.32.0-0ebd4f5-amd64

@zmerlynn zmerlynn merged commit b22ec70 into googleforgames:main Apr 24, 2023
@Kalaiselvi84 Kalaiselvi84 added the kind/feature New features for Agones label May 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New features for Agones size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants