Adds matrix of Agones versions to Kubernetes versions. #2819
Conversation
|
Build Succeeded 👏 Build Id: e0a47afd-cdd4-47cf-acf8-0ba867d5dbbd The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
There was a problem hiding this comment.
Oooh neat! As a quick double check, did this take into account #2279?
We should also update the release checklist to update this at release time as well if the K8s version changes.
|
|
||
| | Agones version | Kubernetes version | | ||
| | -------------- | ------------------ | | ||
| | 1.27 | 1.23 | |
There was a problem hiding this comment.
Should the top row pull the data from the k8s-version and release-version shortcodes?
There was a problem hiding this comment.
Good idea -- I'll add that in.
There was a problem hiding this comment.
I tried adding | {{% release-version %}} | {{% k8s-version %}} | as the top line, but when I ran make site-server ENV=RELEASE_VERSION=1.20 the output was not as expected:
| Agones version | Kubernetes version |
| 1.20 | 1.23 |
Any idea if I'm using the shortcode incorrectly? Or is this an issue with the shortcode itself? Or an issue with the make site-server input args?
There was a problem hiding this comment.
The k8s-version shortcode is hardcoded (here and here), and there is no validation to ensure the mapping between it and the release-version is correct. I think to use make site-server, you have to use the correct environment variable of RELEASE_VERSION, or just do not use any input args so it will pick the correct value by default
There was a problem hiding this comment.
If I'm understanding correctly, it would be better not to add in | {{% release-version %}} | {{% k8s-version %}} | because the release-version is variable and the k8s-version is hard-coded?
|
Build Succeeded 👏 Build Id: 32dbbc33-d6ad-4305-a669-fe147bd3bb7d The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
|
|
||
| Each version of Agones supports a specific version of Kubernetes. When a new version of Agones supports a new version of Kubernetes, it is explicitly called out in the [Agones version release notes](https://agones.dev/site/blog/releases/). | ||
|
|
||
| The following table lists recent Agones versions and their corresponding required Kubernetes versions for Game Servers: |
There was a problem hiding this comment.
nit: Remove the "for Game Servers" bit at the end of the sentence.
| | linux | `amd64` | **Stable** | | ||
| | linux | `arm64` | Alpha | | ||
| | [windows] | `amd64` | Alpha | | ||
|
|
||
| For all the platforms in Alpha, we would appreciate testing and bug reports on any issue found. | ||
|
|
||
| ## Agones and Kubernetes Supported Versions | ||
|
|
||
| Each version of Agones supports a specific version of Kubernetes. When a new version of Agones supports a new version of Kubernetes, it is explicitly called out in the [Agones version release notes](https://agones.dev/site/blog/releases/). |
There was a problem hiding this comment.
nit: Maybe s/Agones version release notes/release notes/ (I think that the first part is implied and doesn't need to be explicit).
|
Build Succeeded 👏 Build Id: 28c7d5f4-eab7-4f35-8c57-21cb1e96c050 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
|
Build Succeeded 👏 Build Id: 0566f2d4-b24a-492f-b425-77d189dc9b8b The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
|
Build Succeeded 👏 Build Id: b4102356-0fee-480a-b8b3-4095c8af2cea The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
mangalpalli
added
the
feature-freeze-do-not-merge
|
Build Succeeded 👏 Build Id: cc72f595-8dee-40fd-a39b-da6b2c4541c9 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
| - [ ] Run `make gen-install` | ||
| - [ ] Run `make test-examples-on-gar` to ensure all example images exist on us-docker.pkg.dev/agones-images/examples | ||
| - [ ] Create a *draft* release with the [release template][release-template] | ||
| - [ ] Make a `tag` with the release version. | ||
| - [ ] Site updated | ||
| - [ ] Copy the draft release content into a new `/site/content/en/blog/releases` content (this will be what you send via email). |
There was a problem hiding this comment.
This file seems to have gained some duplicate lines.
There was a problem hiding this comment.
Ah whoops, looks like I messed up the merge. I'll revert that commit and retry the merge.
There was a problem hiding this comment.
Gah, this PR just got extra messy. I'm going to reset to a previous commit before any merges, and then rebase to main.
|
Build Succeeded 👏 Build Id: 11a12403-8ce0-4d42-ac59-994f9580fa9d The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
|
Build Succeeded 👏 Build Id: adf16192-83c8-4287-97f9-1ee6b967ce91 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
Includes instructions to update Agones to Kubernetes version mapping in release checklist
igooch
force-pushed
the
agones-kubernetes-version-matrix-2237
branch
from
58bc6b6
to
2442953
Compare
|
Build Succeeded 👏 Build Id: 52b34f71-87ea-4927-8343-93e99e123b9d The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gongmax, igooch, roberthbailey The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Merging during the freeze since this is a documentation only change. |
roberthbailey
removed
the
feature-freeze-do-not-merge
…s#2819) Includes instructions to update Agones to Kubernetes version mapping in release checklist
/kind documentation
What this PR does / Why we need it:
This makes the Agones version --> Kubernetes version mappings clear in the overview installation documentation.
Which issue(s) this PR fixes:
Fixes #2237
Special notes for your reviewer:
n/a