-
Notifications
You must be signed in to change notification settings - Fork 801
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The Documentation/Installation page on old releases shows an incorrect Kubernetes version #2279
Comments
Huh! That's super wierd! 🤔 I wonder if it's publishing the dev version of the site, which is showing the next supported version. uuugh - yeah it is: https://github.com/googleforgames/agones/blob/main/site/layouts/shortcodes/k8s-version.html So we don't publish with env HUGO_ENV=production so we don't have duplicate content on search engines (dev content is set to not be indexable). (This is a docsy setting, which I think changed recently) A few thoughts:
|
I'm not sure I understand option 1. If we update hugo / docsy are you saying that will fix this for us? Also, I don't think either option will fix the old releases pages, right? This seems like a good reason to tackle #2237 (and we can add a note/warning that the old release docs may show an incorrect version). |
Not separate options, just separate thoughts. Basically that if we are going to make a change, we may want to upgrade the tooling now as we will have to do it later. Not a fix, just saying the work streams might align, but it's not neccessary. Also, won't fix previous versions - would need to backport the change to release branches and then redeploy. |
Adding some extra notes here for reference:
|
Incorrect installation documentation under the release specific website are in bold. The non-matching Agones versions are: 1.22, 1.18, 1.16, 1.15, 1.12, 1.10, 1.5. There are a few exceptions to the pattern where it's publishing the next-supported version of Kubernetes. Pattern exceptions: Agones versions 1.25, 1.8, 1.3, 1.1. |
I am wondering if #2808 will help here, since @mangalpalli has already done the work to subtract a minor version from the current version -- we could pass that through as the version to actually be reported. |
Based on the docsy link you listed, it looks like production is the default environment for hugo. I don't see that we're passing any other environment to hugo, unless I'm missing something? |
No, we don't pass anything else through - my suggestion in #2279 (comment) would be to pass a different env values to We do now have a specific Make target to be used specifically at release time: agones/build/includes/release.mk Lines 60 to 66 in a4caaeb
So we could add this new variable / value in there and it would get passed all the way through. This is the cloudbuild script that pushes to production for the canonical production version of the website: Lines 40 to 48 in a4caaeb
|
What happened:
During a recent community meeting someone asked the best way to tell which version of Kubernetes is supported by each Agones release. @markmandel suggested looking at the older releases of the website, specifically the https://agones.dev/site/docs/installation/ page, to see what version they suggest.
However, I just checked a few old versions and noticed that they are showing the wrong version of Kubernetes!
From the blog releases, we can see that:
However, if you look at the Install documentation for these releases, we see a different story:
What you expected to happen:
I expect that the website for an old release shows the correct Kubernetes version to install for that release.
The text was updated successfully, but these errors were encountered: