Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use properties where possible in KspExtension #2035

Merged
merged 3 commits into from
Aug 22, 2024
Merged

Use properties where possible in KspExtension #2035

merged 3 commits into from
Aug 22, 2024

Commits on Aug 21, 2024

  1. Use properties where possible in KspExtension 

    This PR converts all internal things in KspExtension to be properties
instead of lists and maps. This will ensure that reads are deferred for
as long as possible and will prevent forcing reads during configuration.

Unfortunately some properties cannot be changed without causing changes
to the ABI. New properties could be introduced but the names would have
to be different.
    @ansman
    ansman committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    5b53471 View commit details
    Browse the repository at this point in the history

  2. Fix the ktlint violations

    @ansman
    ansman committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    2ecaf41 View commit details
    Browse the repository at this point in the history

  3. Fix the broken tests

    @ansman
    ansman committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    3a58ab0 View commit details
    Browse the repository at this point in the history