Use properties where possible in KspExtension #2035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansman
commented
Aug 19, 2024
gradle-plugin/src/main/kotlin/com/google/devtools/ksp/gradle/KspExtension.kt
Show resolved
Hide resolved
ansman
force-pushed
the
feature/property-support
branch
from
dff4aeb
to
f4c96a3
Compare
ansman
commented
Aug 19, 2024
gradle-plugin/src/main/kotlin/com/google/devtools/ksp/gradle/KspSubplugin.kt
Show resolved
Hide resolved
ting-yuan
approved these changes
Aug 20, 2024
This PR converts all internal things in KspExtension to be properties instead of lists and maps. This will ensure that reads are deferred for as long as possible and will prevent forcing reads during configuration. Unfortunately some properties cannot be changed without causing changes to the ABI. New properties could be introduced but the names would have to be different.
ansman
force-pushed
the
feature/property-support
branch
from
34f373e
to
c1f89d9
Compare
ansman
force-pushed
the
feature/property-support
branch
from
c1f89d9
to
3a58ab0
Compare
|
Thank you so much for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR converts all internal things in KspExtension to be properties instead of lists and maps. This will ensure that reads are deferred for as long as possible and will prevent forcing reads during configuration.
Unfortunately some properties cannot be changed without causing changes to the ABI. New properties could be introduced but the names would have to be different.
This partially fixes #1752