Add setMediaListAndPlay to PlayerRepository #497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 16, 2022
Merged
yschimke
reviewed
Aug 22, 2022
|
|
||
| // when | ||
| sut.setMediaListAndPlay(mediaList, 1) | ||
| runUntilPendingCommandsAreFullyHandled(player) |
There was a problem hiding this comment.
How do we know we can rely on this still? Does runUntilPendingCommandsAreFullyHandled, wait until the items are resolved and then we get onTimelineChangedcalled on the main thread?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
Add
setMediaListAndPlaytoPlayerRepositorywith a workaround implementation for #495.WHY
In order to be able to play an item at specific index.
In order to be able to set the media list and seek to a specific index without having an intermediate emission from
PlayerRepository.mediaPosition.HOW
Checklist 📋