Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert workaround to fix playing songs at specific index #496

Closed
luizgrp opened this issue Aug 16, 2022 · 2 comments
Closed

Revert workaround to fix playing songs at specific index #496

luizgrp opened this issue Aug 16, 2022 · 2 comments
Labels
Media UI Media UI related

Comments

@luizgrp
Copy link
Member

luizgrp commented Aug 16, 2022

After androidx/media#85 gets fixed and media3 dependency is updated in the project, revert changes made in #497 that are a workaround for this issue:

  • mediaIndexToSeekTo and onTimelineChanged should be removed;
  • calls to seekTo, prepare and play should be made by setMediaListAndPlay;

As alternative, function setMediaListAndPlay should be removed and a setMediaList(mediaList, index) added instead. setMediaListAndPlay is taking care of playing at the moment to avoid having clients to code a "delay" call as per in #494

@luizgrp luizgrp added the Media UI Media UI related label Aug 16, 2022
@fstanis
Copy link
Contributor

fstanis commented Sep 30, 2022

As of #646, reverting these two things in PlayerRepositoryImpl.kt:

  • Remove private fun updateTimeline
  • Remove EVENT_TIMELINE_CHANGED from eventHandlers

@luizgrp
Copy link
Member Author

luizgrp commented Dec 7, 2022

androidx/media#85 was fixed in 1.0.0-beta03, this can be reverted as we are already using that version.

kul3r4 added a commit to kul3r4/horologist-1 that referenced this issue Dec 13, 2022
@kul3r4 kul3r4 closed this as completed in 730d4ac Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Media UI Media UI related
Projects
None yet
Development

No branches or pull requests

2 participants