refactor: convert blocksvg and block to ES6 classes #5952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
25 tasks
BeksOmega
requested review from
alschmiedt
and removed request for
NeilFraser
alschmiedt
approved these changes
Feb 25, 2022
BeksOmega
force-pushed
the
refact/block-to-es6
branch
from
20e784b
to
7cc375b
Compare
alschmiedt
reviewed
Feb 26, 2022
alschmiedt
approved these changes
Feb 28, 2022
BeksOmega
force-pushed
the
refact/block-to-es6
branch
from
428db94
to
0d3e0af
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Work on #5860
Proposed Changes
Reorganizes the Block and BlockSvg constructors so that they can be converted to to ES6 classes.
I originally did this by adding an optional
skipInitparameter to the Block, but since Maribeth revealed to menew.targetI think that would be a better solution. However, I'm posting this PR first so as to theoretically lessen the confusion in my commit history. (Rewriting history pre-running the conversion script is beyond me)Should be no behavioral changes 🤞
Reason for Changes
Getting slowly closer to typescript.
Test Coverage
All tests pass.
Documentation
N/A
Additional Information
The changes in files besides Block and BlockSvg are casts to make the compiler happy. Apparently it gets more strict when we conver things to ES6 classes.