Where possible, convert to es6 classes.

[rachel-fenichel]

Problematic classes (an incomplete list):

• generator.js (Handled in refactor: convert some classes to ES6 classes #5928)
  • Acts as both a struct and a dict. We add properties after creation (like a dict) but also do . access (like a struct).
    • Can be fixed with the @unrestricted annotation on the class. --@rachel-fenichel
  • Uses Object.defineProperties to add a property to the prototype.
• options.js (Handled in refactor: convert some classes to ES6 classes #5928)
  • Has a couple of functions (setMetrics and getMetrics) that don't always exist, but are declared for type purposes. Uses check whether these functions exist.
    • Declare these as data properties with @type {function(....):... | undefined}. --@cpcallen
• shortcut_registry.js (Handled in refactor: convert registry files to es6 classes #5940)
  • Weird singleton pattern.
• contextmenu_registry.js (Handled in refactor: convert registry files to es6 classes #5940)
  • Weird singleton pattern.
• registry.js (Handled in refactor: convert registry files to es6 classes #5940)
• block_svg.js (Handled in refactor: convert blocksvg and block to ES6 classes #5952)
  • Calls the super constructor late
• block.js (Handled in refactor: convert blocksvg and block to ES6 classes #5952)
  • Has an unconverted subclass

Toolbox

• toolbox/category.js (Handled in refactor: convert toolbox items to ES6 classes #5947)
  • Has an unconverted subclass (CollapsibleCategory)
• toolbox/collapsible_category.js (Handled in refactor: convert toolbox items to ES6 classes #5947)
  • I think the problem is that the superclass constructor uses the registrationName static property, which the subclass overrides. The property isn't overridden yet when the superclass constructor is called.
• toolbox/toolbox_item.js (Handled in refactor: convert toolbox items to ES6 classes #5947)
  • Has an unconverted subclass (ToolboxCategory)

Rendering:

• renderers/geras/path_object.js (Handled in refactor: convert PathObject to an ES6 class #5954)
  • Extends the base path object but doesn't call the super constructor. That's because the geras path object has to put a dark path in front of the main path, and z-index of svg objects is controlled by the order in which they are created.
• renderers/common/path_object.js (Handled in refactor: convert PathObject to an ES6 class #5954)
  • Has a non-converted subclass (see above)
• renderers/measurables/row.js (Handled in refactor: convert row.js and base.js to ES6 classes #5957)
  • In code we add a few properties (followsStatement, nextRightEdge, and rightAlignedDummyInput) that don't really belong on this class. I could just add and describe them anyway, marked as package, if really necessary.
• renderers/measurables/base.js (Handled in refactor: convert row.js and base.js to ES6 classes #5957)
  • Similar story to measurables/row.js

Fields:

• field.js (Handled in refactor: Convert fields to ES6 classes #5943)
  • Has multiple unconverted subclasses.
• field_textinput.js (Handled in refactor: Convert fields to ES6 classes #5943)
  • Sets this.spellcheck_ = true before calling the super constructor, and breaks if the order changes.
• field_number.js (Handled in refactor: Convert fields to ES6 classes #5943)
  • Sets multiple properties before calling the super constructor, and breaks if the order changes.
• field_image.js (Handled in refactor: Convert fields to ES6 classes #5943)
  • Sets multiple properties before calling the super constructor, and breaks if the order changes.
• `field_label.js (Handled in refactor: Convert fields to ES6 classes #5943)
• field_dropdown.js (Handled in refactor: Convert fields to ES6 classes #5943)
• field_colour.js (Handled in refactor: Convert fields to ES6 classes #5943)
• field_variable.js (Handled in refactor: Convert fields to ES6 classes #5943)
• field_angle.js (Handled in refactor: Convert fields to ES6 classes #5943)

Events:

• events_abstract.js (Handled in refactor: convert some classes to ES6 classes #5928)
• workspace_events.js (Handled in refactor: convert some classes to ES6 classes #5928)

[BeksOmega]

• workspace.js
• renderer.js in common
• dropdowndiv.js