-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate kapt to ksp #2471
Migrate kapt to ksp #2471
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
thanks for this pr this looks fine to me if tests pass |
@icrc-fdeniger i took the liberty of changing the title of the pr and added a commit that fixes the build - hopefully it'll get auto-merged once tests pass. |
knowledge/src/main/java/com/google/android/fhir/knowledge/db/dao/KnowledgeDao.kt
Show resolved
Hide resolved
Head branch was pushed to by a user without write access
push a new version with something similar to other plugins. |
I fixed some unit tests:
Some tests are still failing and I suppose it's due to my locale:
|
I believe the test failing in QuestionnaireUiEspressoTest is |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for testing these out on Windows.
thanks for these! we shouldn't have tests that fail in different locales if that's the problem we should def fix it. |
got ya - can you take a look at this? |
FYI I have created #2485 re. the flaky |
Hello, thanks for your answers. Is there another step to let this PR be accepted ? I see that Kokoro step is still pending but I can't have the details. |
I (only now, didn't look before) noticed that it already has 2 approvals and auto-merge, so it just needs a green build, then it will go in.
There were some problems which were just solved, see #2485 and #2488, I've tried to click Update branch to see if it helps. |
@icrc-fdeniger following the merge of #2463 there is a small conflict - can you have a look and (manually) resolve that? Tx! |
IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).
Fixes #2470
Description
To be polished.
Alternative(s) considered
Have to run the demo in admin mode on windows but not possible due to our entreprise policy
Type
Bug fix
Screenshots (if applicable)
Checklist
./gradlew spotlessApply
and./gradlew spotlessCheck
to check my code follows the style guide of this project../gradlew check
and./gradlew connectedCheck
to test my changes locally.