-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dokka version, fix knowledge task #2463
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@williamito - thanks for this. but can you please explain why we need to add the local directory and remote url info in the dokka config?
@williamito thanks for this! Before we merge this, give me a few days to "test" this - I'll try something to build on top of my recent #2460 and #2461, to actually runs this, not locally, but directly on GitHub, hopefully some time in the next few days. |
ok @vorburger i've disabled auto merge. but i'm fine with this being merged. so please feel free to. |
I've now tested this as part of working on #2483 and seen that it works great, so I'm merging; thanks @williamito ! |
IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).
Fixes #2237
Description
Update dokka version, add missing configuration code to knowledge doc task.
Alternative(s) considered
Type
Choose one: Bug fix
Screenshots (if applicable)
Checklist
./gradlew spotlessApply
and./gradlew spotlessCheck
to check my code follows the style guide of this project../gradlew check
and./gradlew connectedCheck
to test my changes locally.