Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dokka version, fix knowledge task #2463

Merged
merged 7 commits into from
Mar 18, 2024
Merged

Conversation

williamito
Copy link
Contributor

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).

Fixes #2237

Description
Update dokka version, add missing configuration code to knowledge doc task.

Alternative(s) considered

Type
Choose one: Bug fix

Screenshots (if applicable)

Checklist

  • I have read and acknowledged the Code of conduct.
  • I have read the Contributing page.
  • I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA.
  • I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach.
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project.
  • I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally.
  • I have built and run the demo app(s) to verify my change fixes the issue and/or does not break the demo app(s).

Copy link
Collaborator

@jingtang10 jingtang10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@williamito - thanks for this. but can you please explain why we need to add the local directory and remote url info in the dokka config?

@jingtang10 jingtang10 enabled auto-merge (squash) March 6, 2024 14:18
@vorburger vorburger requested review from jingtang10 and removed request for aditya-07 March 6, 2024 17:21
@vorburger vorburger self-assigned this Mar 6, 2024
@vorburger
Copy link
Member

vorburger commented Mar 6, 2024

@williamito thanks for this! Before we merge this, give me a few days to "test" this - I'll try something to build on top of my recent #2460 and #2461, to actually runs this, not locally, but directly on GitHub, hopefully some time in the next few days.

@jingtang10 jingtang10 disabled auto-merge March 6, 2024 17:37
@jingtang10
Copy link
Collaborator

ok @vorburger i've disabled auto merge. but i'm fine with this being merged. so please feel free to.

@vorburger
Copy link
Member

ok @vorburger i've disabled auto merge. but i'm fine with this being merged. so please feel free to.

I've now tested this as part of working on #2483 and seen that it works great, so I'm merging; thanks @williamito !

@vorburger vorburger enabled auto-merge (squash) March 16, 2024 01:05
@vorburger
Copy link
Member

This fails to auto-merge due to #2485. Either #2486 (if the team agrees) or a "real" fix of that problem will unblock it.

This is holding up #2483.

@vorburger vorburger merged commit 9519473 into google:master Mar 18, 2024
4 checks passed
@vorburger vorburger mentioned this pull request Mar 18, 2024
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

./gradlew dokkaHtml fails
4 participants