Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make shutdown timeout configurable #1806

Merged
merged 1 commit into from
Jan 24, 2023
Merged

Make shutdown timeout configurable #1806

merged 1 commit into from
Jan 24, 2023

Commits on Jan 23, 2023

  1. Make shutdown timeout configurable

    Currently, when shutting down the server (via SIGINT or SIGTERM), the
    shutdown closes any open connections after only 10 seconds (via a
    context.WithTimeout). This does not provie a lot of time for longer
    operations, such as listing versions, or downloading a larger module zip
    file.
    
    When running in Kubernetes, and scaling instances or changing config,
    this causes a lot of dropped connections and gateway errors. 10 seconds
    is arguably much too short, and should be configurable.
    
    This commit increases that default to 60 seconds, and adds a config
    variable to allow users to specify their desired timeout.
    jorng committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    b683517 View commit details
    Browse the repository at this point in the history