Make shutdown timeout configurable #1806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nrwiersma
approved these changes
Jan 19, 2023
nrwiersma
requested changes
Jan 19, 2023
Currently, when shutting down the server (via SIGINT or SIGTERM), the shutdown closes any open connections after only 10 seconds (via a context.WithTimeout). This does not provie a lot of time for longer operations, such as listing versions, or downloading a larger module zip file. When running in Kubernetes, and scaling instances or changing config, this causes a lot of dropped connections and gateway errors. 10 seconds is arguably much too short, and should be configurable. This commit increases that default to 60 seconds, and adds a config variable to allow users to specify their desired timeout.
|
Rebased and fixed the failing test. |
manugupt1
approved these changes
Jan 24, 2023
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the problem I am trying to address?
Currently, when shutting down the server (via
SIGINT), the shutdown closes any open connections after only 10 seconds (via acontext.WithTimeout). This does not provie a lot of time for longer operations, such as listing versions, or downloading a larger module zip file.When running in Kubernetes, and scaling instances or changing config, this causes a lot of dropped connections and gateway errors. 10 seconds is arguably much too short, and should be configurable.
How is the fix applied?
This commit increases that default to 60 seconds, and adds a config variable to allow users to specify their desired timeout.