Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go 1.11.4 mod checksum errors #29278

Closed
nictuku opened this issue Dec 15, 2018 · 11 comments
Closed

go 1.11.4 mod checksum errors #29278

nictuku opened this issue Dec 15, 2018 · 11 comments

Comments

@nictuku
Copy link
Contributor

nictuku commented Dec 15, 2018

$ go version
go version go1.11.4 linux/amd64

$ go get ./...

or

$ go mod download
go: verifying gotest.tools@v2.2.0+incompatible: checksum mismatch
downloaded: h1:VsBPFP1AI068pPrMxtb/S8Zkgf9xEmTLJjfM+P5UIEo=
go.sum: h1:y0IMTfclpMdsdIbr6uwmJn5/WZ7vFuObxDMdrylFM3A=

Switch to Go 1.11.3

Nuke $GOPATH/pkg/mod/cache

Repeat go get ./... or go mod download, and it works.

I'm creating a simple repo with repro steps now.

@nictuku
Copy link
Contributor Author

nictuku commented Dec 15, 2018

Perhaps this was because the checksums created by 1.11.3 were the "wrong" ones? So nuking the cache is probably fine?

@dotwaffle
Copy link

dotwaffle commented Dec 15, 2018

No, definitely not 1.11.3, my checksum was made back in August and is broken as of 1.11.4, whereas it worked with 1.11 thru 1.11.3 without showing errors:

go: verifying github.com/grpc-ecosystem/go-grpc-middleware@v1.0.0: checksum mismatch
    downloaded: h1:Iju5GlWwrvL6UBg4zJJt3btmonfrMlCDdsejg4CZE7c=
    go.sum:     h1:BWIsLfhgKhV5g/oF34aRjniBHLTZe5DNekSjbAjIS6c=

@agnivade
Copy link
Contributor

/cc @bcmills @myitcv

@bcmills
Copy link
Contributor

bcmills commented Dec 15, 2018

Yes, pre-1.11.4, modules containing symlinks were constructed erroneously. 1.11.4 correctly omits those symlinks, which may change the sums for a few (hopefully isolated) modules.

@bcmills
Copy link
Contributor

bcmills commented Dec 15, 2018

See #27093.

@nictuku
Copy link
Contributor Author

nictuku commented Dec 15, 2018

It sounds like we can close this issue. It's an inconvenient but ultimately benign error caused by previous versions.

It can be worked around by manually updating (or simply removing) the appropriate lines from go.sum.

@thepudds
Copy link
Contributor

Note: if you have a copy of a module with symlinks in your module cache, you likely will need to run go clean -modcache in order to get 1.11.4 to generate the new (corrected) checksum. (e.g., see #29282)

fsouza pushed a commit to nytimes/video-captions-api that referenced this issue Dec 18, 2018
fsouza pushed a commit to video-dev/video-transcoding-api that referenced this issue Dec 18, 2018
Should fix the build (broken by go.sum, see golang/go#29278).
rmasp added a commit to aspiration-labs/pyggpot that referenced this issue Apr 20, 2019
arssher added a commit to arssher/hodgepodge that referenced this issue May 21, 2019
sbawaska pushed a commit to projectriff-archive/cnab-k8s-installer-base that referenced this issue May 21, 2019
* Bump riff dependency to latest

* Adjust indirect dependencies and k8s.io/apimachinery to match the changes in
  riff's Gopkg.lock.
* Move k8s.io/apimachinery dependency from indirect to direct group in go.mod.
* Redo go.sum based on Go 1.11.4 after `go clean -modcache`. See:
    - golang/go#29278
    - golang/go#29282
* Add go.sum entries for Windows

* Make unit tests pass and image relocate work on Windows

Fixes https://github.com/pivotal-cf/pfs/issues/175
Fixes https://github.com/pivotal-cf/pfs/issues/135
fivesheep pushed a commit to fivesheep/opencensus-service that referenced this issue Jun 12, 2019
…on#283)

* Remove broken checksums now caught by go 1.11.4

See golang/go#29278 for more info.

* Update related MD files

* Fix build_binaries docker
vadbluedata pushed a commit to bluedatainc/lvmd that referenced this issue Jun 25, 2019
vadbluedata pushed a commit to bluedatainc/lvmd that referenced this issue Jun 25, 2019
vadbluedata added a commit to bluedatainc/lvmd that referenced this issue Jun 25, 2019
sbawaska pushed a commit to projectriff/k8s-manifest-scanner that referenced this issue Jul 16, 2019
* Bump riff dependency to latest

* Adjust indirect dependencies and k8s.io/apimachinery to match the changes in
  riff's Gopkg.lock.
* Move k8s.io/apimachinery dependency from indirect to direct group in go.mod.
* Redo go.sum based on Go 1.11.4 after `go clean -modcache`. See:
    - golang/go#29278
    - golang/go#29282
* Add go.sum entries for Windows

* Make unit tests pass and image relocate work on Windows

Fixes https://github.com/pivotal-cf/pfs/issues/175
Fixes https://github.com/pivotal-cf/pfs/issues/135
mmrath pushed a commit to mmrath/dex that referenced this issue Sep 2, 2019
Go 1.11.3 changed how checksums are created in some cases, which caused
failures building via modules. (ref golang/go#29278)

Update the checksums for the failing modules.

To catch this is the future, a modules build was added to the build matrix. I
also noted that we were pinning the `.0` patchlevel of each go version which
wouldn't have picked this up, updated it to build with the latest patch
release.
g-k pushed a commit to mozilla-services/autograph-edge that referenced this issue Oct 9, 2019
g-k pushed a commit to mozilla-services/autograph-edge that referenced this issue Oct 10, 2019
@golang golang locked and limited conversation to collaborators Feb 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

8 participants