Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update hashes to be compatible for go>=1.11.4 #21

Merged
merged 1 commit into from
Sep 6, 2019
Merged

update hashes to be compatible for go>=1.11.4 #21

merged 1 commit into from
Sep 6, 2019

Conversation

femnad
Copy link
Collaborator

@femnad femnad commented Apr 21, 2019

Hello,

The way Go modules construct hashes for dependencies has been changed in Go 1.11.4 (a related issue here) and this causes hash mismatches when the kcfishgen module is built with a Go version of greater than 1.11.4, like the following

verifying k8s.io/kubernetes@v1.12.0: checksum mismatch
        downloaded: h1:2PjG+1oSb9SSwFkJIH6HZH85CDfJ7hOaMMMQYi1Q+0c=
        go.sum:     h1:jPDApxpqyQ/THiLnquNHidiHC1F8jvDi7BUGfNtue30=

This patch updates hashes of three dependencies to make the main module buildable with Go >= 1.11.4.

There is one caveat though; applying this patch may require the folks who have previously compiled with a Go version of less than 1.11.4 to perform a go clean -modcache to force a recalculation of the hashes for the dependencies which were affected by the mismatches.

Thanks.

@evanlucas evanlucas merged commit 4647e9e into evanlucas:master Sep 6, 2019
@evanlucas
Copy link
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants