v3(enhancement): remove `utils.Trim*` because stdlib has same performance in go1.19 #2030

trim21 · 2022-08-19T14:47:07Z

This pr remove Trim, TrimRight and TrimLeft.

Stdlib functions have save performance now.

ReneWerner87 · 2022-08-19T14:56:20Z

can you check my last comments from the old one ?
https://github.com/gofiber/fiber/blob/v3-beta/utils/bytes.go#L59

…byteSeq

efectn

can you update benchmarks on README.md

trim21 · 2022-08-19T15:19:52Z

do you considering using https://github.com/stretchr/testify instead of current AssertEqual 🤔

trim21 · 2022-08-19T15:21:20Z

can you update benchmarks on README.md

done

trim21 · 2022-08-19T15:21:54Z

I just keep the old tests and benchmark as bytes inputs

trim21 · 2022-08-19T15:45:44Z

ctx.go

@@ -1245,7 +1245,7 @@ func (c *DefaultCtx) WriteString(s string) (int, error) {
 // XHR returns a Boolean property, that is true, if the request's X-Requested-With header field is XMLHttpRequest,
 // indicating that the request was issued by a client library (such as jQuery).
 func (c *DefaultCtx) XHR() bool {
-	return utils.EqualFoldBytes(utils.UnsafeBytes(c.Get(HeaderXRequestedWith)), []byte("xmlhttprequest"))
+	return utils.EqualFold(c.Get(HeaderXRequestedWith), "xmlhttprequest")


why do we use EqualFoldBytes instead of EqualFold in the first place?

trim21 · 2022-08-20T03:15:05Z

I saw the updated benchmark result, I think we can remove these Trim* functions now 🤔

go 1.19

Benchmark_TrimRightBytes/fiber-16               100000000               10.66 ns/op            8 B/op          1 allocs/op
Benchmark_TrimRightBytes/default-16             100000000               10.84 ns/op            8 B/op          1 allocs/op

Benchmark_TrimLeftBytes/fiber-16                100000000               10.72 ns/op            8 B/op          1 allocs/op
Benchmark_TrimLeftBytes/default-16              100000000               11.29 ns/op            8 B/op          1 allocs/op

Benchmark_TrimBytes/fiber-16                    74933964                15.43 ns/op           16 B/op          1 allocs/op
Benchmark_TrimBytes/default-16                  74931624                15.86 ns/op           16 B/op          1 allocs/op

Benchmark_TrimRight/fiber-16                    484963700                2.471 ns/op           0 B/op          0 allocs/op
Benchmark_TrimRight/default-16                  454740096                2.614 ns/op           0 B/op          0 allocs/op

Benchmark_TrimLeft/fiber-16                     488699834                2.451 ns/op           0 B/op          0 allocs/op
Benchmark_TrimLeft/default-16                   423590457                2.835 ns/op           0 B/op          0 allocs/op

Benchmark_Trim/fiber-16                         296457481                4.023 ns/op           0 B/op          0 allocs/op
Benchmark_Trim/default-16                       322653328                3.804 ns/op           0 B/op          0 allocs/op
Benchmark_Trim/default.trimspace-16             248519290                4.811 ns/op           0 B/op          0 allocs/op

1.18 , our version is a little bit faster.

goos: windows
goarch: amd64
pkg: github.com/gofiber/fiber/v3/utils
cpu: AMD Ryzen 7 5800X 8-Core Processor
Benchmark_TrimRightBytes/fiber-16               100000000               10.49 ns/op            8 B/op          1 allocs/op
Benchmark_TrimRightBytes/default-16             99912576                11.57 ns/op            8 B/op          1 allocs/op

Benchmark_TrimLeftBytes/fiber-16                100000000               10.42 ns/op            8 B/op          1 allocs/op
Benchmark_TrimLeftBytes/default-16              99905920                11.55 ns/op            8 B/op          1 allocs/op

Benchmark_TrimBytes/fiber-16                    70524762                16.44 ns/op           16 B/op          1 allocs/op
Benchmark_TrimBytes/default-16                  70530980                16.72 ns/op           16 B/op          1 allocs/op

Benchmark_TrimRight/fiber-16                    865098051                1.398 ns/op           0 B/op          0 allocs/op
Benchmark_TrimRight/default-16                  487361299                2.470 ns/op           0 B/op          0 allocs/op

Benchmark_TrimLeft/fiber-16                     760135455                1.569 ns/op           0 B/op          0 allocs/op
Benchmark_TrimLeft/default-16                   419346405                2.895 ns/op           0 B/op          0 allocs/op

Benchmark_Trim/fiber-16                         309708110                3.745 ns/op           0 B/op          0 allocs/op
Benchmark_Trim/default-16                       302284438                4.009 ns/op           0 B/op          0 allocs/op
Benchmark_Trim/default.trimspace-16             250067830                4.784 ns/op           0 B/op          0 allocs/op
PASS
ok      github.com/gofiber/fiber/v3/utils       17.530s

efectn · 2022-08-20T05:20:02Z

I saw the updated benchmark result, I think we can remove these Trim* functions now 🤔

go 1.19

Benchmark_TrimRightBytes/fiber-16               100000000               10.66 ns/op            8 B/op          1 allocs/op
Benchmark_TrimRightBytes/default-16             100000000               10.84 ns/op            8 B/op          1 allocs/op

Benchmark_TrimLeftBytes/fiber-16                100000000               10.72 ns/op            8 B/op          1 allocs/op
Benchmark_TrimLeftBytes/default-16              100000000               11.29 ns/op            8 B/op          1 allocs/op

Benchmark_TrimBytes/fiber-16                    74933964                15.43 ns/op           16 B/op          1 allocs/op
Benchmark_TrimBytes/default-16                  74931624                15.86 ns/op           16 B/op          1 allocs/op

Benchmark_TrimRight/fiber-16                    484963700                2.471 ns/op           0 B/op          0 allocs/op
Benchmark_TrimRight/default-16                  454740096                2.614 ns/op           0 B/op          0 allocs/op

Benchmark_TrimLeft/fiber-16                     488699834                2.451 ns/op           0 B/op          0 allocs/op
Benchmark_TrimLeft/default-16                   423590457                2.835 ns/op           0 B/op          0 allocs/op

Benchmark_Trim/fiber-16                         296457481                4.023 ns/op           0 B/op          0 allocs/op
Benchmark_Trim/default-16                       322653328                3.804 ns/op           0 B/op          0 allocs/op
Benchmark_Trim/default.trimspace-16             248519290                4.811 ns/op           0 B/op          0 allocs/op

1.18 , our version is a little bit faster.

goos: windows
goarch: amd64
pkg: github.com/gofiber/fiber/v3/utils
cpu: AMD Ryzen 7 5800X 8-Core Processor
Benchmark_TrimRightBytes/fiber-16               100000000               10.49 ns/op            8 B/op          1 allocs/op
Benchmark_TrimRightBytes/default-16             99912576                11.57 ns/op            8 B/op          1 allocs/op

Benchmark_TrimLeftBytes/fiber-16                100000000               10.42 ns/op            8 B/op          1 allocs/op
Benchmark_TrimLeftBytes/default-16              99905920                11.55 ns/op            8 B/op          1 allocs/op

Benchmark_TrimBytes/fiber-16                    70524762                16.44 ns/op           16 B/op          1 allocs/op
Benchmark_TrimBytes/default-16                  70530980                16.72 ns/op           16 B/op          1 allocs/op

Benchmark_TrimRight/fiber-16                    865098051                1.398 ns/op           0 B/op          0 allocs/op
Benchmark_TrimRight/default-16                  487361299                2.470 ns/op           0 B/op          0 allocs/op

Benchmark_TrimLeft/fiber-16                     760135455                1.569 ns/op           0 B/op          0 allocs/op
Benchmark_TrimLeft/default-16                   419346405                2.895 ns/op           0 B/op          0 allocs/op

Benchmark_Trim/fiber-16                         309708110                3.745 ns/op           0 B/op          0 allocs/op
Benchmark_Trim/default-16                       302284438                4.009 ns/op           0 B/op          0 allocs/op
Benchmark_Trim/default.trimspace-16             250067830                4.784 ns/op           0 B/op          0 allocs/op
PASS
ok      github.com/gofiber/fiber/v3/utils       17.530s

I agree

trim21 added 6 commits August 19, 2022 22:20

EqualFold

ec67ed4

add comment

a11948a

rewrite test

af9e321

test

367bac4

revert

ea87324

revert

b5ca5cb

trim21 marked this pull request as ready for review August 19, 2022 14:47

trim21 mentioned this pull request Aug 19, 2022

✨ v3 (enhancement): add []byte support to utils.EqualFold #2029

Merged

trim21 changed the title ~~v3(tests): use a table driven test for utils.EqualFold~~ v3(enhancement): convert more utils to generic byteSeq function. Aug 19, 2022

trim21 marked this pull request as draft August 19, 2022 15:02

trim21 added 3 commits August 19, 2022 23:05

rewrite more

e9c2785

Merge remote-tracking branch 'upstream/v3-beta' into v3-util-genetic-…

98c970f

…byteSeq

remove use of old utils

fe74c29

trim21 marked this pull request as ready for review August 19, 2022 15:12

add bytes test

7adecc7

efectn reviewed Aug 19, 2022

View reviewed changes

update benchmark

f5a96dd

trim21 commented Aug 19, 2022

View reviewed changes

comment

71637c1

trim21 added 🧹 Updates v3 labels Aug 20, 2022

trim21 added 2 commits August 20, 2022 10:01

rewrite test

b745816

rewrite test

cd7fa21

trim21 requested a review from efectn August 20, 2022 03:32

remove trim functions

40ebbf0

remove usage of utils

964ea5f

trim21 changed the title ~~v3(enhancement): convert more utils to generic byteSeq function.~~ v3(enhancement): remove utils.Trim* because stdlib has save performance now Aug 20, 2022

trim21 changed the title ~~v3(enhancement): remove utils.Trim* because stdlib has save performance now~~ v3(enhancement): remove utils.Trim* because stdlib has same performance now Aug 20, 2022

trim21 changed the title ~~v3(enhancement): remove utils.Trim* because stdlib has same performance now~~ v3(enhancement): remove utils.Trim* because stdlib has same performance in go1.19 Aug 20, 2022

assert

f9f62c8

trim21 merged commit b161f80 into gofiber:v3-beta Aug 20, 2022

trim21 deleted the v3-util-genetic-byteSeq branch August 20, 2022 05:52

efectn added this to the v3 milestone Sep 8, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

v3(enhancement): remove `utils.Trim*` because stdlib has same performance in go1.19 #2030

v3(enhancement): remove `utils.Trim*` because stdlib has same performance in go1.19 #2030

trim21 commented Aug 19, 2022 •

edited

Loading

ReneWerner87 commented Aug 19, 2022

efectn left a comment

trim21 commented Aug 19, 2022

trim21 commented Aug 19, 2022

trim21 commented Aug 19, 2022 •

edited

Loading

trim21 Aug 19, 2022

trim21 commented Aug 20, 2022 •

edited

Loading

efectn commented Aug 20, 2022

v3(enhancement): remove utils.Trim* because stdlib has same performance in go1.19 #2030

v3(enhancement): remove utils.Trim* because stdlib has same performance in go1.19 #2030

Conversation

trim21 commented Aug 19, 2022 • edited Loading

ReneWerner87 commented Aug 19, 2022

efectn left a comment

Choose a reason for hiding this comment

trim21 commented Aug 19, 2022

trim21 commented Aug 19, 2022

trim21 commented Aug 19, 2022 • edited Loading

trim21 Aug 19, 2022

Choose a reason for hiding this comment

trim21 commented Aug 20, 2022 • edited Loading

efectn commented Aug 20, 2022

v3(enhancement): remove `utils.Trim*` because stdlib has same performance in go1.19 #2030

v3(enhancement): remove `utils.Trim*` because stdlib has same performance in go1.19 #2030

trim21 commented Aug 19, 2022 •

edited

Loading

trim21 commented Aug 19, 2022 •

edited

Loading

trim21 commented Aug 20, 2022 •

edited

Loading