v3(enhancement): remove utils.Trim* (#2030)

stdlib functions have same performance in go1.19

ctx.go

@@ -108,9 +108,9 @@ func (c *DefaultCtx) Accepts(offers ...string) string {
 	for len(header) > 0 && commaPos != -1 {
 		commaPos = strings.IndexByte(header, ',')
 		if commaPos != -1 {
-			spec = utils.Trim(header[:commaPos], ' ')
+			spec = strings.TrimLeft(header[:commaPos], " ")
 		} else {
-			spec = utils.TrimLeft(header, ' ')
+			spec = strings.TrimLeft(header, " ")
 		}
 		if factorSign := strings.IndexByte(spec, ';'); factorSign != -1 {
 			spec = spec[:factorSign]
@@ -508,10 +508,10 @@ func (c *DefaultCtx) IPs() (ips []string) {
 	for {
 		commaPos = bytes.IndexByte(header, ',')
 		if commaPos != -1 {
-			ips[i] = utils.Trim(c.app.getString(header[:commaPos]), ' ')
+			ips[i] = strings.Trim(c.app.getString(header[:commaPos]), " ")
 			header, i = header[commaPos+1:], i+1
 		} else {
-			ips[i] = utils.Trim(c.app.getString(header), ' ')
+			ips[i] = strings.Trim(c.app.getString(header), " ")
 			return
 		}
 	}
@@ -526,7 +526,7 @@ func (c *DefaultCtx) Is(extension string) bool {
 	}
 
 	return strings.HasPrefix(
-		utils.TrimLeft(utils.UnsafeString(c.fasthttp.Request.Header.ContentType()), ' '),
+		strings.TrimLeft(utils.UnsafeString(c.fasthttp.Request.Header.ContentType()), " "),
 		extensionHeader,
 	)
 }
@@ -597,7 +597,7 @@ func (c *DefaultCtx) Links(link ...string) {
 			_, _ = bb.WriteString(`; rel="` + link[i] + `",`)
 		}
 	}
-	c.setCanonical(HeaderLink, utils.TrimRight(c.app.getString(bb.Bytes()), ','))
+	c.setCanonical(HeaderLink, strings.TrimRight(c.app.getString(bb.Bytes()), ","))
 	bytebufferpool.Put(bb)
 }
 
@@ -1245,7 +1245,7 @@ func (c *DefaultCtx) WriteString(s string) (int, error) {
 // XHR returns a Boolean property, that is true, if the request's X-Requested-With header field is XMLHttpRequest,
 // indicating that the request was issued by a client library (such as jQuery).
 func (c *DefaultCtx) XHR() bool {
-	return utils.EqualFoldBytes(utils.UnsafeBytes(c.Get(HeaderXRequestedWith)), []byte("xmlhttprequest"))
+	return utils.EqualFold(c.Get(HeaderXRequestedWith), "xmlhttprequest")
 }
 
 // configDependentPaths set paths for route recognition and prepared paths for the user,
@@ -1267,7 +1267,7 @@ func (c *DefaultCtx) configDependentPaths() {
 	}
 	// If StrictRouting is disabled, we strip all trailing slashes
 	if !c.app.config.StrictRouting && len(c.detectionPathBuffer) > 1 && c.detectionPathBuffer[len(c.detectionPathBuffer)-1] == '/' {
-		c.detectionPathBuffer = utils.TrimRightBytes(c.detectionPathBuffer, '/')
+		c.detectionPathBuffer = bytes.TrimRight(c.detectionPathBuffer, "/")
 	}
 	c.detectionPath = c.app.getString(c.detectionPathBuffer)
 

helpers.go

@@ -17,7 +17,6 @@ import (
 	"time"
 	"unsafe"
 
-	"github.com/gofiber/fiber/v3/utils"
 	"github.com/valyala/bytebufferpool"
 	"github.com/valyala/fasthttp"
 )
@@ -223,7 +222,7 @@ func getGroupPath(prefix, path string) string {
 		path = "/" + path
 	}
 
-	return utils.TrimRight(prefix, '/') + path
+	return strings.TrimRight(prefix, "/") + path
 }
 
 // return valid offer for header negotiation
@@ -238,7 +237,7 @@ func getOffer(header string, offers ...string) string {
 	for len(header) > 0 && commaPos != -1 {
 		commaPos = strings.IndexByte(header, ',')
 		if commaPos != -1 {
-			spec = utils.Trim(header[:commaPos], ' ')
+			spec = strings.TrimSpace(header[:commaPos])
 		} else {
 			spec = header
 		}

middleware/filesystem/filesystem.go

@@ -8,7 +8,6 @@ import (
 	"sync"
 
 	"github.com/gofiber/fiber/v3"
-	"github.com/gofiber/fiber/v3/utils"
 )
 
 // Config defines the config for middleware.
@@ -133,7 +132,7 @@ func New(config ...Config) fiber.Handler {
 		)
 
 		if len(path) > 1 {
-			path = utils.TrimRight(path, '/')
+			path = strings.TrimRight(path, "/")
 		}
 		file, err = cfg.Root.Open(path)
 		if err != nil && os.IsNotExist(err) && cfg.NotFoundFile != "" {
@@ -153,7 +152,7 @@ func New(config ...Config) fiber.Handler {
 
 		// Serve index if path is directory
 		if stat.IsDir() {
-			indexPath := utils.TrimRight(path, '/') + cfg.Index
+			indexPath := strings.TrimRight(path, "/") + cfg.Index
 			index, err := cfg.Root.Open(indexPath)
 			if err == nil {
 				indexStat, err := index.Stat()
@@ -226,7 +225,7 @@ func SendFile(c fiber.Ctx, fs http.FileSystem, path string) (err error) {
 
 	// Serve index if path is directory
 	if stat.IsDir() {
-		indexPath := utils.TrimRight(path, '/') + ConfigDefault.Index
+		indexPath := strings.TrimRight(path, "/") + ConfigDefault.Index
 		index, err := fs.Open(indexPath)
 		if err == nil {
 			indexStat, err := index.Stat()

middleware/filesystem/utils.go

@@ -10,7 +10,6 @@ import (
 	"strings"
 
 	"github.com/gofiber/fiber/v3"
-	"github.com/gofiber/fiber/v3/utils"
 )
 
 func getFileExtension(path string) string {
@@ -41,7 +40,7 @@ func dirList(c fiber.Ctx, f http.File) error {
 	fmt.Fprint(c, "<ul>")
 
 	if len(basePathEscaped) > 1 {
-		parentPathEscaped := html.EscapeString(utils.TrimRight(c.Path(), '/') + "/..")
+		parentPathEscaped := html.EscapeString(strings.TrimRight(c.Path(), "/") + "/..")
 		fmt.Fprintf(c, `<li><a href="%s" class="dir">..</a></li>`, parentPathEscaped)
 	}
 

path.go

@@ -13,7 +13,6 @@ import (
 	"time"
 	"unicode"
 
-	"github.com/gofiber/fiber/v3/utils"
 	"github.com/google/uuid"
 )
 
@@ -51,6 +50,7 @@ const (
 	optionalParam                byte = '?'  // concludes a parameter by name and makes it optional
 	paramStarterChar             byte = ':'  // start character for a parameter with name
 	slashDelimiter               byte = '/'  // separator for the route, unlike the other delimiters this character at the end can be optional
+	slashDelimiterStr                 = "/"  // separator for the route, unlike the other delimiters this character at the end can be optional
 	escapeChar                   byte = '\\' // escape character
 	paramConstraintStart         byte = '<'  // start of type constraint for a parameter
 	paramConstraintEnd           byte = '>'  // end of type constraint for a parameter
@@ -159,7 +159,7 @@ func addParameterMetaInfo(segs []*routeSegment) []*routeSegment {
 		} else {
 			comparePart = segs[i].Const
 			if len(comparePart) > 1 {
-				comparePart = utils.TrimRight(comparePart, slashDelimiter)
+				comparePart = strings.TrimRight(comparePart, slashDelimiterStr)
 			}
 		}
 	}
@@ -354,7 +354,7 @@ func findNextCharsetPositionConstraint(search string, charset []byte) int {
 		if char == paramConstraintEnd {
 			constraintEnd = pos
 		}
-		//fmt.Println(string(char))
+		// fmt.Println(string(char))
 		if pos != -1 && (pos < nextPosition || nextPosition == -1) {
 			if pos > constraintStart && pos < constraintEnd {
 				nextPosition = pos

router.go

@@ -188,7 +188,7 @@ func (app *App) addPrefixToRoute(prefix string, route *Route) *Route {
 	}
 	// Strict routing, remove trailing slashes
 	if !app.config.StrictRouting && len(prettyPath) > 1 {
-		prettyPath = utils.TrimRight(prettyPath, '/')
+		prettyPath = strings.TrimRight(prettyPath, "/")
 	}
 
 	route.Path = prefixedPath
@@ -246,7 +246,7 @@ func (app *App) register(method, pathRaw string, handlers ...Handler) Router {
 	}
 	// Strict routing, remove trailing slashes
 	if !app.config.StrictRouting && len(pathPretty) > 1 {
-		pathPretty = utils.TrimRight(pathPretty, '/')
+		pathPretty = strings.TrimRight(pathPretty, "/")
 	}
 	// Is layer a middleware?
 	isUse := method == methodUse