Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pathwatcher #92

Merged
merged 5 commits into from
Nov 28, 2015
Merged

Pathwatcher #92

merged 5 commits into from
Nov 28, 2015

Conversation

heavyk
Copy link
Contributor

@heavyk heavyk commented Oct 27, 2015

hi @Rich-Harris

I noticed the gobble process for our project (it has a lot of files) was using a shitload of cpu while idle. I looked into it and it was all the polling done by chokidar. the cpu was churning away on the 100 zillion files being watched/served by gobble. so, I decided I would upgrade chokidar to pathwatcher. it's used in the atom editor and runs fine on windows, linux and osx.

so check this: after doing the conversion what was previously 3-7% constant cpu usage on the gobble process (once, up to 12% when I didn't restart the process for about a week) -- has now become literally zero. none. not one bit. I am not seeing such huge memory blowout over time either.

been testing this for a little while now and it's solid as a rock man.

super happy! cheers!

@heavyk
Copy link
Contributor Author

heavyk commented Oct 27, 2015

ooops got an error on travis. it's true I didn't try it on linux yet.

I'll get it working. our servers are linux :)

@heavyk heavyk force-pushed the pathwatcher branch 5 times, most recently from 9f5c9ea to a0c07a6 Compare October 27, 2015 03:00
@heavyk
Copy link
Contributor Author

heavyk commented Oct 27, 2015

got it!

had to refactor the code because the tests stop and start a bunch (and I forgot to clean the garbage). then, I had to use clang for travis (because they have an old gcc which doesn't support c++0x).

ok, good nite

also, refactor a bit and conform to "rich-code-formatting" (rcf format)
Rich-Harris added a commit that referenced this pull request Nov 28, 2015
@Rich-Harris Rich-Harris merged commit 7c77ba4 into gobblejs:master Nov 28, 2015
@Rich-Harris
Copy link
Contributor

Hey @heavyk, sorry for leaving this open so long! Haven't had a chance to check in on this project in a while. Will admit I haven't tried pathwatcher but if it's used in Atom then it's bound to be pretty solid, and it sounds like you've had a good experience with it so 👍. We can always revert later if it turns out to be a bad move, but I have a good feeling. Will try and push out a new release this weekend. Thanks

@Swatinem
Copy link

Swatinem commented Dec 1, 2015

👍 Sounds nice!
I have also seen it constantly pegging the CPU, but not that high. It was maxing one core though when I had a watch on node_modules once. So I’m happy to see that solved.
Also looking for the lower memory usage that you mentioned. It could reach up to ~800M for me through a few days of usage with a lot of rebuilds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants