-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pathwatcher #92
Pathwatcher #92
Conversation
ooops got an error on travis. it's true I didn't try it on linux yet. I'll get it working. our servers are linux :) |
9f5c9ea
to
a0c07a6
Compare
got it! had to refactor the code because the tests stop and start a bunch (and I forgot to clean the garbage). then, I had to use clang for travis (because they have an old gcc which doesn't support c++0x). ok, good nite |
also, refactor a bit and conform to "rich-code-formatting" (rcf format)
Hey @heavyk, sorry for leaving this open so long! Haven't had a chance to check in on this project in a while. Will admit I haven't tried pathwatcher but if it's used in Atom then it's bound to be pretty solid, and it sounds like you've had a good experience with it so 👍. We can always revert later if it turns out to be a bad move, but I have a good feeling. Will try and push out a new release this weekend. Thanks |
👍 Sounds nice! |
hi @Rich-Harris
I noticed the gobble process for our project (it has a lot of files) was using a shitload of cpu while idle. I looked into it and it was all the polling done by chokidar. the cpu was churning away on the 100 zillion files being watched/served by gobble. so, I decided I would upgrade chokidar to pathwatcher. it's used in the atom editor and runs fine on windows, linux and osx.
so check this: after doing the conversion what was previously 3-7% constant cpu usage on the gobble process (once, up to 12% when I didn't restart the process for about a week) -- has now become literally zero. none. not one bit. I am not seeing such huge memory blowout over time either.
been testing this for a little while now and it's solid as a rock man.
super happy! cheers!