Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Watchers for everybody #114

Closed
TrySound opened this issue May 15, 2016 · 6 comments
Closed

Watchers for everybody #114

TrySound opened this issue May 15, 2016 · 6 comments

Comments

@TrySound
Copy link
Member

Hi. I saw issues about chokidar performace and here's my thoughts

  • pathwatcher sucks because depends on python. Not everybody has an access to python
  • chokidar seems good last half yeah. Didn't see performance problems on windows even with native mode (not polling).

So, maybe gobble could revert temporary replacement and everybody will be happy :)

@IvanSanchez
Copy link
Member

Right now pathwatcher is creating a lot of issues in my CI flows, as the runas dependency fails to re-compile every time.

You're not alone in the pathwatcher criticism - there's #108, #115 and #106. According to #92, pathwatcher should be more solid than chokidar, and the project has gone with that so far. I wonder if there's enough reason to go back to chokidar, though.

@sod
Copy link

sod commented Jul 28, 2016

There is also https://github.com/amasad/sane ... e.g. used by jspm :)

@evs-chris
Copy link
Contributor

FWIW I'm super 👍 on getting a fresh version of gobble without pathwatcher out. CI does not like pathwatcher, so we're sticking with an older gobble for now. 😄 It looks like it's already been swapped out in master.

@teehemkay
Copy link

Same here.:+1: on removing pathwatcher since it fails to compile on too many enviromments

@Rich-Harris
Copy link
Contributor

Just released 0.12 with all the accumulated changes (on which note – wow! Sorry, I totally dropped the ball, I don't deserve such good open source friends) including switching back to chokidar, to see if things are any better. Still having a bit of trouble getting stuff to build on Node 7, but hopefully it will fix something...

@teehemkay
Copy link

Thanks Rich! I'll try 0.12 at work on Monday.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants