Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump vue-bar-graph #31705

Merged
merged 2 commits into from
Aug 1, 2024
Merged

bump vue-bar-graph #31705

merged 2 commits into from
Aug 1, 2024

Conversation

techknowlogick
Copy link
Member

The change should be minimal. I've marked this PR as WIP/draft, as I still need to do local testing, but I wanted to get a PR up as quickly as possible. Please wait to review it until I take it out of draft.

@techknowlogick techknowlogick added type/bug skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. modifies/dependencies labels Jul 26, 2024
@GiteaBot GiteaBot added lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jul 26, 2024
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 26, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jul 26, 2024
@wxiaoguang
Copy link
Contributor

wxiaoguang commented Jul 26, 2024 •
edited
Loading

It seems that there was an indirect dependency for "vue-compiler" (the package-lock.json was changed a lot), which affects something like <div class="scoped-access-token-mount"><scoped-access-token-selector></div>. So these dependencies are still necessary (and fortunately they are still there).

Update:

Ideally, there should be no "vue-compiler" for frontend, every Vue component should be compiled when building assets.

It was expected that there should be no Vue compiler after #23421.

(I am just sharing the background, the vue-compiler problem is not directly related to this PR)

@silverwind
Copy link
Member

silverwind commented Jul 26, 2024 •
edited
Loading

Ideally, there should be no "vue-compiler" for frontend, every Vue component should be compiled when building assets.

Yes, runtime dependency on the compiler needs to be removed eventually and moved to webpack, I'm just not sure how to do this as I'm no Vue expert 😆.

@lunny lunny mentioned this pull request Jul 27, 2024
Open
@lunny
Copy link
Member

lunny commented Jul 27, 2024

issue created lafriks/vue-bar-graph#18

@techknowlogick techknowlogick added the backport/v1.22 This PR should be backported to Gitea 1.22 label Aug 1, 2024
@techknowlogick techknowlogick marked this pull request as ready for review August 1, 2024 17:20
@techknowlogick
Copy link
Member Author

This is now ready for review.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Aug 1, 2024
@lafriks lafriks merged commit d128352 into go-gitea:main Aug 1, 2024
26 checks passed
@GiteaBot GiteaBot added this to the 1.23.0 milestone Aug 1, 2024
@techknowlogick techknowlogick deleted the bump-npm-package branch August 1, 2024 18:08
techknowlogick added a commit to techknowlogick/gitea that referenced this pull request Aug 1, 2024
@techknowlogick
bump vue-bar-graph (go-gitea#31705)
8c5b45d
techknowlogick added a commit to techknowlogick/gitea that referenced this pull request Aug 1, 2024
@techknowlogick
bump vue-bar-graph (go-gitea#31705)
21392e3
lafriks pushed a commit that referenced this pull request Aug 1, 2024
@techknowlogick
bump vue-bar-graph (#31705) (#31753)
edf96fc 
backport vue-bar-graph bump to remove gsap dep
@GiteaBot
Copy link
Contributor

GiteaBot commented Aug 1, 2024

I was unable to create a backport for 1.22. @techknowlogick, please send one manually. 🍵

go run ./contrib/backport 31705
...  // fix git conflicts if any
go run ./contrib/backport --continue

@GiteaBot GiteaBot added the backport/manual No power to the bots! Create your backport yourself! label Aug 1, 2024
zjjhot added a commit to zjjhot/gitea that referenced this pull request Aug 2, 2024
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
c400a49 
* giteaofficial/main:
  Clear up old Actions logs (go-gitea#31735)
  Fix createElementFromAttrs bug (go-gitea#31751)
  bump vue-bar-graph (go-gitea#31705)
  Use UTC as default timezone when schedule Actions cron tasks (go-gitea#31742)
  Add permission description for API to add repo collaborator (go-gitea#31744)
  Clarify Actions resources ownership (go-gitea#31724)
  Exclude protected branches from recently pushed (go-gitea#31748)
  [skip ci] Updated translations via Crowdin
  Distinguish LFS object errors to ignore missing objects during migration (go-gitea#31702)
@lunny lunny added the backport/done All backports for this PR have been created label Aug 2, 2024
@wxiaoguang
Copy link
Contributor

-> scoped-access-token-mount not mounted anymore #31771

Eventually, it is broken

@lafriks
Copy link
Member

lafriks commented Aug 3, 2024

@wxiaoguang because of the vue bar graph?

@wxiaoguang
Copy link
Contributor

@wxiaoguang because of the vue bar graph?

yes

@lafriks
Copy link
Member

lafriks commented Aug 3, 2024

How? They are not even in the same page 🤔

@wxiaoguang
Copy link
Contributor

I have explained it #31705 (comment)

And you could check out the commit before this PR to test.

@silverwind
Copy link
Member

silverwind commented Aug 4, 2024 •
edited
Loading

Could it be that vue loads twice or something?

I know similar issues with react with components that have dependency on react-dom which causes react to go haywire when it loads multiple times on the same page.

@lafriks I think you should check what the common practices are for publishing vue components. Check other popular components how they do it.

@lafriks
Copy link
Member

lafriks commented Aug 4, 2024

I have and in vite vue is already set as external library/dependency and are not included in library

@wxiaoguang wxiaoguang mentioned this pull request Aug 6, 2024
Closed
@lunny lunny mentioned this pull request Sep 6, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lunny lunny lunny approved these changes

@lafriks lafriks lafriks approved these changes

@wxiaoguang wxiaoguang wxiaoguang approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created backport/manual No power to the bots! Create your backport yourself! backport/v1.22 This PR should be backported to Gitea 1.22 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/dependencies modifies/js size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/bug
Projects
None yet
Milestone
1.23.0
Development

Successfully merging this pull request may close these issues.
6 participants
@techknowlogick @wxiaoguang @silverwind @lunny @GiteaBot @lafriks