Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unnecessary dependencies on vue compiler #18

Open
lunny opened this issue Jul 27, 2024 · 3 comments
Open

Unnecessary dependencies on vue compiler #18

lunny opened this issue Jul 27, 2024 · 3 comments

Comments

@lunny
Copy link

lunny commented Jul 27, 2024

ref: go-gitea/gitea#31705 (comment)

@lafriks
Copy link
Owner

lafriks commented Jul 29, 2024

What exactly needs to be done about that? 🤔

@silverwind
Copy link

silverwind commented Aug 1, 2024

I'm not sure but I think the module entry file should maybe just export the SFC alone, if that is possible.

import VueBarGraph from './components/VueBarGraph.vue';
export {VueBarGraph};

Check how other vue component libraries export their components.

@silverwind
Copy link

silverwind commented Aug 1, 2024

Also I guess vue should be in peerDependencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants