Ruby: Bump rust toolchain to 1.68 #12529
Conversation
hmac
force-pushed
the
ruby-extractor-bump-rust-version
branch
from
6bcdd4f
to
9eda668
Compare
hmac
force-pushed
the
ruby-extractor-bump-rust-version
branch
from
41e3abb
to
e7ead76
Compare
This is primarily to bust the build cache.
hmac
force-pushed
the
ruby-extractor-bump-rust-version
branch
from
48a6053
to
d4020ad
Compare
.github/workflows/ruby-build.yml
Outdated
| - name: Fetch CodeQL | ||
| uses: ./.github/actions/fetch-codeql | ||
|
|
||
| # Due to a bug in Actions, we can't use runner.temp here. |
There was a problem hiding this comment.
Are you sure that ${{ runner.temp }} does not work? It looks like things are supposed to be fixed in actions/runner#1762 .
There was a problem hiding this comment.
Looking at the failed run https://github.com/github/codeql/actions/runs/4442367661/jobs/7798560621 it seems the bug was only half-fixed by actions/runner#1762 ...
The use of ${{ github.temp }} in the with clause of the download step was expanded correctly: `https://github.com/github/codeql/actions/runs/4442367661/jobs/7798560621
with:
name: codeql-ruby-bundle
path: /home/runner/work/_temp
but the variable was expanded wrongly in the run: step:
unzip -q -d "/home/runner/work/_temp/ruby-bundle" "/home/runner/work/_temp/codeql-ruby-bundle.zip"
There was a problem hiding this comment.
I see that others have tried to work around the problem by using the environment variables instead. Might be worth a shot to use "$RUNNER_TEMP" in the run: steps. This is actually better in general and avoids potential path injection attacks if a variable contains a " (unlikely for the runner.temp variable, but plausible for some user provided ones).
There was a problem hiding this comment.
I'll give that a try and see if it works.
This should not affect our support for systems with older glibc versions (e.g. Centos 7), and it will allow us to use newer library versions and Cargo features.
In addition, I've added a specific test that runs the extractor in a Centos 7 container, to ensure that we don't break this compatibility in future.