Use StepHost when evaluating inputs to actions

[nikola-jokic]

Closes #716

[thboop]

LGTM

Let me double check how we convert these for other variables, it this not getting converted for some reason?

[ChristopherHX]

it this not getting converted for some reason?

You are only converting the environment variables, no single expressions contexts has ever been translated to a container path.
Even paths of custom environment variables get converted
e.g.
The following prints host path

- run: echo '${{github.workspace}}'
  shell: bash

The following two prints the container path

- run: echo  $WP
  env:
    WP: ${{github.workspace}}
  shell: bash

- run: echo  $GITHUB_WORKSPACE
  shell: bash

GITHUB_ACTION_PATH already holds the container path, but the composite docs suggest to use ${{ github.action_path }} in a run step to call a bash script, which leads to problems.

[thboop]

So, this does solve the issue for this specific context variable, however this problem exists for ALL path based context variables. For example consider the composite action:

  using: "composite"
  steps:
    - run: printenv
      shell: bash
    - run: |
        echo ${{github.action_path}}
        echo ${{github.event_path}}
        echo ${{github.workspace}}
      shell: bash

The env's will get translated, the echo statements will not. What we should really do is in Actionsrunner where we evaluate step inputs, use the step host to modify the context

            // TODO: Translate expression values into container expression values and pass that in here.
            // TODO: Temp create another dictionary for expression values and feed it in here, we need to map the path based containers to push it in.
            var inputs = templateEvaluator.EvaluateStepInputs(Action.Inputs, ExecutionContext.ExpressionValues, ExecutionContext.ExpressionFunctions);

[TingluoHuang]

Can we update the PR description to include an output of dumping github and runner context with your changes? want to make sure all values are expected. 🙇

[nikola-jokic]

@TingluoHuang of course! I will fix all of the suggestions as soon as I can 👍

[fhammerl]

LGTM!

[faubion-hbo]

Hi,
i'm running on the latest github runner (2.290.1) that should have this fix in it, but am still seeing a difference between the outputs of $GITHUB_ACTION_PATH and ${{ github.action_path }} when running a job within a container where ${{ github.action_path }} doesn't map to the right directory. i.e.

${{ github.action_path }} == /home/runner/work/_actions/<org>/<action>/<tag>
$GITHUB_ACTION_PATH == /__w/_actions/<org>/<action>/<tag>

where the container image is being pulled from ECR

[fhammerl]

@faubion-hbo We recognised this as a sensitive change and rolling it out gradually.
Thanks for reporting the issue here, you can expect the fix to land in a few days.

[AllanOricil]

does not work. I had to change echo "${{ github.action_path }}" >> $GITHUB_PATH to echo "$GITHUB_ACTION_PATH" >> $GITHUB_PATH

[zachspar]

The problem still exists on self-hosted runners (actions-runner-controller) using defined container value.