Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for selecting multiple albums by regex #251

Merged
merged 1 commit into from
Jul 27, 2020
Merged

Add support for selecting multiple albums by regex #251

merged 1 commit into from
Jul 27, 2020

Conversation

rogerdahl
Copy link
Contributor

No description provided.

@gilesknap
Copy link
Owner

This looks good. It looks like the travis tests did not run though. I can't imagine why this is unless something has changed on github.

@gilesknap gilesknap merged commit 086b9c1 into gilesknap:master Jul 27, 2020
@gilesknap
Copy link
Owner

Oh wait, its just me. I won't see Travis runs from a fork. There does appear to be a failure in one system test however it is not related to your code changes. Rather it is seeing a bug in a new version of exif dependency see #250.

Many thanks for a really useful PR.

@rogerdahl
Copy link
Contributor Author

Thanks for this project. The code is really well written and easy to work with :)

@gilesknap
Copy link
Owner

Hey thanks. Its been fun to write, but I must confess that my attention to this project is waning. Google's lack of attention to the issues in #119 is leading me to investigate alternative photos hosting projects.

I'm not going to abandon gphotos-sync but would be interested in having some collaborators. Your PR showed a good understanding of the code, so I'm inviting you as collaborator. Feel free to refuse if this is not of interest!

@rogerdahl
Copy link
Contributor Author

@gilesknap Thank you for the offer! Unfortunately, I have to decline due to time constrains, and because I don't want to make any promises that I can't keep. I still want to help though. Which of the current issues do you think would be a good one to start with?

@gilesknap
Copy link
Owner

No worries (note that accepting just means you have write permission to this repo - it does not come with any specific commitment!)

Thanks for the offer of looking at an issue.

Some possibilities are:
#244 should be quite easy and is stopping a couple of people from using gphotos-sync
#250 is an easy fix but would be worth discussing with the author of the exif library (who is very responsive)
#238 would be a little more involved but not that hard and useful for lots of people.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants