Replace walrus #474
Merged
Replace walrus #474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
26 tasks
Swatinem
reviewed
Dec 20, 2021
Jake-Shadle
force-pushed
the
replace-walrus
branch
from
042bbb9
to
38e187b
Compare
Jake-Shadle
force-pushed
the
replace-walrus
branch
from
38e187b
to
cc961a8
Compare
Swatinem
approved these changes
Dec 20, 2021
|
Awesome stuff! |
This was referenced Jan 12, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opening as a draft since this PR depends on #470
As stated in #472, this PR removes walrus due to its passively maintained status, and instead uses
wasmparserdirectly. This means that not only canwasmparserbe upgraded to follow the latest version much more easily and remove a dependency, it also means the runtime memory usage and CPU time should be greatly reduced as walrus was doing a lot more work when parsing than this implementation, which (other than the bits needed for validation) only parses the sections/content actually used by this crate.Resolves: #472