Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WASM instruction addresses are incorrect #490

Closed
Jake-Shadle opened this issue Jan 12, 2022 · 0 comments · Fixed by #491
Closed

WASM instruction addresses are incorrect #490

Jake-Shadle opened this issue Jan 12, 2022 · 0 comments · Fixed by #491

Comments

@Jake-Shadle
Copy link
Contributor

After my change in #474 it seems that the instruction addresses are wrong in many cases. Unfortunately the current test case for wasm is too simplistic to catch the error, but I immediately noticed it when symbolicating a stack trace from one of our own modules. I'm just filing this bug for visibility, I plan on fixing this tomorrow (hopefully).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix WASM symbolication EmbarkStudios/symbolic
2 participants
@Swatinem @Jake-Shadle