-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ref(sentry_apps): Move SentryAppInstallation model to sentry_apps #77649
Merged
Christinarlong
merged 19 commits into
master
from
christinarlong/move-sentryapps-models-sai
Sep 18, 2024
Merged
ref(sentry_apps): Move SentryAppInstallation model to sentry_apps #77649
Christinarlong
merged 19 commits into
master
from
christinarlong/move-sentryapps-models-sai
Sep 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
Automatically applied to PRs that change backend components
label
Sep 17, 2024
…ong/move-sentryapps-models-sai
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #77649 +/- ##
==========================================
+ Coverage 78.09% 78.15% +0.05%
==========================================
Files 6979 6961 -18
Lines 309707 308815 -892
Branches 50695 50515 -180
==========================================
- Hits 241859 241339 -520
+ Misses 61423 61066 -357
+ Partials 6425 6410 -15 |
…ong/move-sentryapps-models-sai
markstory
approved these changes
Sep 18, 2024
@@ -56,48 +55,6 @@ def get_projects(self, token: ApiToken | AuthenticatedToken) -> QuerySet[Project | |||
|
|||
return Project.objects.filter(organization_id=token.organization_id) | |||
|
|||
def get_related_sentry_app_components( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏 Nice to see this leave.
Christinarlong
deleted the
christinarlong/move-sentryapps-models-sai
branch
September 18, 2024 21:06
harshithadurai
pushed a commit
that referenced
this pull request
Sep 19, 2024
harshithadurai
pushed a commit
that referenced
this pull request
Sep 19, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cool potatoes, let's move SentryAppInstallation (SAI) to new home :D
relies on/branched off of (#77521)