Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(sentry_apps): Move SentryAppInstallation model to sentry_apps #77649

Merged
merged 19 commits into from
Sep 18, 2024

Conversation

Christinarlong
Copy link
Contributor

@Christinarlong Christinarlong commented Sep 17, 2024

Cool potatoes, let's move SentryAppInstallation (SAI) to new home :D

relies on/branched off of (#77521)

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Sep 17, 2024
Copy link

codecov bot commented Sep 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #77649      +/-   ##
==========================================
+ Coverage   78.09%   78.15%   +0.05%     
==========================================
  Files        6979     6961      -18     
  Lines      309707   308815     -892     
  Branches    50695    50515     -180     
==========================================
- Hits       241859   241339     -520     
+ Misses      61423    61066     -357     
+ Partials     6425     6410      -15     

@@ -56,48 +55,6 @@ def get_projects(self, token: ApiToken | AuthenticatedToken) -> QuerySet[Project

return Project.objects.filter(organization_id=token.organization_id)

def get_related_sentry_app_components(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 Nice to see this leave.

@Christinarlong Christinarlong marked this pull request as ready for review September 18, 2024 20:16
@Christinarlong Christinarlong requested a review from a team as a code owner September 18, 2024 20:16
@Christinarlong Christinarlong requested review from a team as code owners September 18, 2024 20:16
@Christinarlong Christinarlong merged commit 652f6c0 into master Sep 18, 2024
50 checks passed
@Christinarlong Christinarlong deleted the christinarlong/move-sentryapps-models-sai branch September 18, 2024 21:06
@github-actions github-actions bot locked and limited conversation to collaborators Oct 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants