ref(sentry_apps): move sentryapp model to sentry_apps dir #77521
+340
−333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #77521 +/- ##
==========================================
+ Coverage 78.08% 78.12% +0.04%
==========================================
Files 6973 6958 -15
Lines 309431 308884 -547
Branches 50655 50548 -107
==========================================
- Hits 241610 241325 -285
+ Misses 61398 61156 -242
+ Partials 6423 6403 -20 |
Christinarlong
commented
Sep 17, 2024
There was a problem hiding this comment.
delete apps.py shim so that we won't get circular import errors from django 🌵
|
Literally hero level work, thank you. |
markstory
approved these changes
Sep 18, 2024
harshithadurai
pushed a commit
that referenced
this pull request
Sep 19, 2024
harshithadurai
pushed a commit
that referenced
this pull request
Sep 19, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's start migrating Sentry App resources starting witht he SentryApp model & test !
ref(#73857)
relies on (#77614) & (https://github.com/getsentry/getsentry/pull/15146)