Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies for v2023.5 #917

Merged
merged 1 commit into from
Dec 14, 2023
Merged

Update dependencies for v2023.5 #917

merged 1 commit into from
Dec 14, 2023

Conversation

matthew-white
Copy link
Member

Closes #868.

When I run npm ci on the master branch, I see the following warning:

npm WARN EBADENGINE Unsupported engine {
npm WARN EBADENGINE   package: '@achrinza/node-ipc@9.2.6',
npm WARN EBADENGINE   required: {
npm WARN EBADENGINE     node: '8 || 9 || 10 || 11 || 12 || 13 || 14 || 15 || 16 || 17 || 18 || 19'
npm WARN EBADENGINE   },
npm WARN EBADENGINE   current: { node: 'v20.10.0', npm: '10.2.3' }
npm WARN EBADENGINE }

I think this is related to our upgrade to Node 20 (#899). However, after I updated @achrinza/node-ipc, the warning went away.

I also ran npm audit fix, which resolved @babel/traverse and partially resolved postcss. I think we'll need to move away from Vue CLI to fully resolve postcss (#671). However, I also don't think the postcss issue affects us.

Resolving axios required a change to the major version. I updated from 0.22.0 to 1.6.2 (!). This is the change that I think has the most risk. However, tests continue to pass. axios is such a widely used package, and we don't use it in very complicated ways, so I'm hopeful that even though it's a big change, we won't run into issues.

What has been done to verify that this works as intended?

Tests continue to pass. We'll also see whether any issues come up during regression testing.

Before submitting this PR, please make sure you have:

  • run npm run test and npm run lint and confirmed all checks still pass OR confirm CircleCI build passes
  • verified that any code or assets from external sources are properly credited in comments or that everything is internally sourced

Closes #868.

I ran the following commands:

npm update @achrinza/node-ipc
npm audit fix
npm uninstall axios
npm install axios
@matthew-white matthew-white merged commit 8a8e5c0 into master Dec 14, 2023
1 check passed
@matthew-white matthew-white deleted the update-deps branch December 14, 2023 05:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update dependencies for v2023.5
2 participants