Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce development environment instructions to Elasticsearch 8.11.3 #7866

Merged

Conversation

jodygarnett
Copy link
Contributor

@jodygarnett jodygarnett commented Mar 14, 2024

Thanks for the pointers in the PSC meeting about running Elasticsearch 8.11.3 (as defined in pom.xml "es.version" file).

  • Enforce check of es/README.md
  • Enforce check of es/docker-compose.yml

This PR gathers several outstanding PRs:

Checklist

  • I have read the contribution guidelines
  • Pull request provided for main branch, backports managed with label
  • Good housekeeping of code, cleaning up comments, tests, and documentation
  • Clean commit history broken into understandable chucks, avoiding big commits with hundreds of files, cautious of reformatting and whitespace changes
  • Clean commit messages, longer verbose messages are encouraged
  • API Changes are identified in commit messages
  • Testing provided for features or enhancements using automatic tests
  • User documentation provided for new features or enhancements in manual
  • Build documentation provided for development instructions in README.md files
  • Library management using pom.xml dependency management. Update build documentation with intended library use and library tutorials or documentation

- missing kibana configuration provided by Pierre Mauduit (via geonetwork#6284)
- using latest geonetwork image (rather htan 3.99.0)
- Setup and document docker folder as independent testing environments
@jodygarnett jodygarnett force-pushed the build_docker_elasticsearch_8_guidance branch from d306f24 to 3a90098 Compare March 15, 2024 07:40
@jodygarnett jodygarnett marked this pull request as ready for review March 15, 2024 08:14
@jodygarnett jodygarnett changed the title Update development environment instructions to Elasticsearch 8.11.3 Enforce development environment instructions to Elasticsearch 8.11.3 Mar 15, 2024
es/es-dashboards/README.md Outdated Show resolved Hide resolved
docker/README.md Outdated Show resolved Hide resolved
docker/gn-cas-ldap/README.md Outdated Show resolved Hide resolved
docker/gn-postgres/README.md Outdated Show resolved Hide resolved
docker/gn-postgres/docker-compose.yml Show resolved Hide resolved
<plugins>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-enforcer-plugin</artifactId>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does this work?

I've tried: mvn enforcer:enforce and get the following error:

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-enforcer-plugin:3.4.1:enforce (default-cli) on project gn-es-dashboards: No rules are configured. Use the skip flag if you want to disable execution. -> [Help 1

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why you are getting that error, it was correctly failing the build if I ran in the wrong version of maven.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is used by steps such as compile, for example mvn compile will fail if I set the maven version to one newer than installed on my computer:

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-enforcer-plugin:3.4.1:enforce (enforce-maven) on project geonetwork: 
[ERROR] Rule 0: org.apache.maven.enforcer.rules.version.RequireMavenVersion failed with message:
[ERROR] Detected Maven Version: 3.9.5 is not in the allowed range [4.0.9,).

Accept feedback from review

Co-authored-by: Jose García <josegar74@gmail.com>
@josegar74 josegar74 merged commit e7d520b into geonetwork:main Apr 15, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants