-
-
Notifications
You must be signed in to change notification settings - Fork 489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document use of Elasticsearch 7.6.2 via Apache License 2.0, with a note on license change for 7.11.0 onward #5800
Conversation
The current version used for ES is Line 1447 in d2141aa
We need to have clear how the license change affects GeoNetwork, to check if we can continue with this version or need to downgrade to |
The use of ES version 7.11 and greater requires GeoCat products, notably GeoNetwork Enterprise, and GeoCat Live to use a non-open source component in order to function. This does not align with our company values. It is prudent to hold the version at 7.10.2 while the PSC or geonetwork user meeting assesses this matter. |
I went to use main today and noticed this was not yet merged |
According to this: https://www.elastic.co/guide/en/elasticsearch/client/java-rest/current/java-rest-high-compatibility.html
Afaik, that means we can use the High Level Client version |
I recommend accepting this pull request (both to have consistent documentation on what to run) and to provide some space for the PSC to make a plan. |
todo: Add curl command to troubelshooting section:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is definitely necessary in my opinion, thanks @jodygarnett.
Added to troubleshooting section as this is a common problem when working on a laptop.
Can this be merged please? |
From my experience, unfortunately version 7.10.1 and 7.10.2 are not good choices to work with GeoNetwork 4 and will probably in most catalog content cases fail to index properly the full content due to an issue on Elasticsearch (related to update of mapping with range type). On my side I've projects working fine with version from 7.5.x to 7.12.x; but you should consider not fixing the version to 7.10.2. |
@fxprunayre I am not sure what to say…
If the PR is not going be merged, or is here approved and not merged, please reject it so I can get on with life. I cannot manage to work on main due to these issues, and would prefer to work with the rest of the team. |
Like what version should we put here that works? |
Here in the PR we have 2 topics:
For the version, I'm only saying that most of GN users will probably end up on elastic/elasticsearch#69012 if it is set to 7.10.2. I've not tested all versions, only raising a warning on this one. |
Okay I get it a known bug with 7.10.2. What is a good revision you would recommend (ignoring the license issue for now, I can always make a new PR - but I need to be able to work on main in order to contribute to GN4) |
Checking release history:
So the challenge is to determine if the date_range bug is fixed in 6.8.14? |
I am searching to find the exact commit for the date_range bug fix so we can figure out if it is available in an apache licensed branch. I am not sure if all the branches changed license, or just 7.11.0 onward ... elastic/elasticsearch#69012 (comment) indicates 7.9 did not have this issue as of Feb 16th 2021... |
Signed-off-by: Jody Garnett <jody.garnett@gmail.com>
@fxprunayre thanks for the discussion, changed this PR to make 7.6.2 consistent across the documentation and various ways of starting up. I selected 7.6.2 as it was used by most of the codebase (so I assume it is tested). |
The PSC has decided to go with Easlsticsearch, Amazon has since setup Opensearch which is a viable fallback if we run into issue with Business Software License conflicts. The troubleshooting advise form this PR has been added to #7866 |
See https://www.elastic.co/pricing/faq/licensing for Elasticsearch license change from 7.11 onward.
Update: 7.10.2 has a known date_time issue, alternatives include: