-
-
Notifications
You must be signed in to change notification settings - Fork 489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Translation pack / Add gnui bundle and transifex update. #5445
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok perfect, I had 2 small questions.
Thanks
@@ -0,0 +1,27 @@ | |||
{ | |||
"facets.block.title.OrgForResource": "Organisation", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could those field be removed from gn-ui i18n files ? couldn't we get them from somewhere in the backend ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the long run, yes that sounds the way to go. We have a database API for storing custom translations #4823 but we lack a UI for people to manage them in the admin - we missed the opportunity to have that funded by geocat.ch ... it will come at some point. Then indeed as user can customize facet from the admin, they have to also have the possibility to manage the label of the facet. So it totally makes sense; still a bit of work before that move.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But facet block title are iso19139 element names.. so they are translated already somewhere in the backend, it's not custom translation, is it ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not always, facet are not only related to schema - some of them are related to Index structure (those one are common), some other are dynamic and based on schema element name eg. cl_.... and some facet are custom eg. filter based so indeed we can maybe improve at some point with translations for global index fields, then for schema we are not going to load all schema translations only for 2 facet labels ...
Some are also related to thesaurus title - and quite often end user does not use the thesaurus title as is ... so something to think about.
"nav.back": "Back", | ||
"record.action.download": "Scarica", | ||
"record.action.view": "Vedere", | ||
"record.more.details": "Read more", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok so the english default value is already managed on the backend ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Transifex do that; it copy the "main" language to others. But we still may have the case where GN-UI translation has some keys that are not yet in GN4 API - so in that case it still make sense to have a fallback on GN-UI side to english.
Follows geonetwork/geonetwork-ui#100
http://localhost:8080/geonetwork/srv/api/i18n/packages/gnui