Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gatsby-Starter-Business Updated to Gatsby v2 along with new features #10197

Merged
merged 6 commits into from
Nov 29, 2018
Merged

Gatsby-Starter-Business Updated to Gatsby v2 along with new features #10197

merged 6 commits into from
Nov 29, 2018

Conversation

v4iv
Copy link
Contributor

@v4iv v4iv commented Nov 29, 2018

No description provided.

@v4iv v4iv requested a review from a team November 29, 2018 06:16
LekoArts
LekoArts suggested changes Nov 29, 2018
View reviewed changes
Copy link
Contributor

@LekoArts LekoArts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small changes needed

docs/starters.yml Outdated Show resolved Hide resolved
docs/starters.yml Outdated Show resolved Hide resolved
LekoArts and others added 2 commits November 29, 2018 17:03
@LekoArts @v4iv
Update docs/starters.yml
13b29a4 
Co-Authored-By: v4iv <vaibhavsharmaatwork@gmail.com>
@v4iv
Update starters.yml
6320d77
pieh
pieh approved these changes Nov 29, 2018
View reviewed changes
Copy link
Contributor

@pieh pieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for update!

@pieh pieh merged commit 043b43b into gatsbyjs:master Nov 29, 2018
gpetrioli pushed a commit to gpetrioli/gatsby that referenced this pull request Jan 22, 2019
@v4iv @gpetrioli
Gatsby-Starter-Business Updated to Gatsby v2 along with new features (g…
ddb697f 
…atsbyjs#10197)

<!--
  Q. Which branch should I use for my pull request?
  A. Use `master` branch (probably).

  Q. Which branch if my change is a bug fix for Gatsby v1?
  A. In this case, you should use the `v1` branch

  Q. Which branch if I'm still not sure?
  A. Use `master` branch. Ask in the PR if you're not sure and a Gatsby maintainer will be happy to help :)

  Note: We will only accept bug fixes for Gatsby v1. New features should be added to Gatsby v2.

  Learn more about contributing: https://www.gatsbyjs.org/docs/how-to-contribute/
-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pieh pieh pieh approved these changes

@LekoArts LekoArts LekoArts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@v4iv @pieh @LekoArts