Add line-to-line voltage metrics #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiyash-basu-frequenz
added
the
scope:breaking-change
github-actions
bot
added
part:docs
This commit makes the voltage metric terminals more explicit. Note that, when we say "Voltage", we mean the potential difference between two points in a circuit. So knowing both points in these definitions help readability. Signed-off-by: Tiyash Basu <tiyash.basu@frequenz.com>
Due to how the metrics were numbered, the metrics had to be renumbered. Signed-off-by: Tiyash Basu <tiyash.basu@frequenz.com>
tiyash-basu-frequenz
force-pushed
the
voltage
branch
from
ad11739
to
c65b55e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
METRIC_VOLTAGE_PHASE_[1|2|3]toMETRIC_VOLTAGE_PHASE_[1|2|3]_N.METRIC_VOLTAGE_PHASE_1_PHASE_2METRIC_VOLTAGE_PHASE_2_PHASE_3METRIC_VOLTAGE_PHASE_3_PHASE_1Metrichave been renumberd due to the addition ofline-to-line voltages.
Closes #135