Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Phase to Phase Voltages #135

Closed
matthias-wende-frequenz opened this issue Nov 14, 2023 · 3 comments · Fixed by #206
Closed

Phase to Phase Voltages #135

matthias-wende-frequenz opened this issue Nov 14, 2023 · 3 comments · Fixed by #206
Labels
part:❓ We need to figure out which part is affected priority:❓ We need to figure out how soon this should be addressed scope:breaking-change Breaking change, users will need to update their code type:enhancement New feature or enhancement visitble to users
Milestone
v0.6.0

Comments

@matthias-wende-frequenz
Copy link
Contributor

matthias-wende-frequenz commented Nov 14, 2023 •
edited
Loading

What's needed?

Some electrical consumers draw energy between two phases or from all three phases. At the moment the phase to phase voltage is missing in the metric enum.

Proposed solution

No response

Use cases

No response

Alternatives and workarounds

No response

Additional context

No response
@matthias-wende-frequenz matthias-wende-frequenz added type:enhancement New feature or enhancement visitble to users part:❓ We need to figure out which part is affected priority:❓ We need to figure out how soon this should be addressed labels Nov 14, 2023
@llucax
Copy link
Contributor

llucax commented Nov 15, 2023

Some electrical draw energy between to phases.

This seems a bit confusing...

Maybe "Some electrical devices draw energy between to two phases."?

@tiyash-basu-frequenz tiyash-basu-frequenz added this to the v0.5.2 milestone Dec 6, 2023
@tiyash-basu-frequenz tiyash-basu-frequenz modified the milestones: v0.5.2, v0.5.3 Dec 19, 2023
@llucax llucax modified the milestones: v0.5.4, v0.5.5 Jan 31, 2024
@tiyash-basu-frequenz tiyash-basu-frequenz modified the milestones: v0.5.5, v0.6.0 Feb 16, 2024
@tiyash-basu-frequenz tiyash-basu-frequenz added the scope:breaking-change Breaking change, users will need to update their code label Feb 16, 2024
@tiyash-basu-frequenz
Copy link
Contributor

This will be a breaking change because adding phase-to-phase voltages means that we need to specify the existing metrics as phase-to-neutral, which is not the case now.

@tiyash-basu-frequenz
Copy link
Contributor

In case of single-phase systems, what happens to the phase-to-phase voltages? I need to check.

Merged
github-merge-queue bot pushed a commit that referenced this issue Mar 22, 2024
@tiyash-basu-frequenz
Add line-to-line voltage metrics (#206)
387edab 
This PR
- Voltage metrics have been renamed from `METRIC_VOLTAGE_PHASE_[1|2|3]`
to `METRIC_VOLTAGE_PHASE_[1|2|3]_N`.
- The following new metrics have been added:
  - `METRIC_VOLTAGE_PHASE_1_PHASE_2`
  - `METRIC_VOLTAGE_PHASE_2_PHASE_3`
  - `METRIC_VOLTAGE_PHASE_3_PHASE_1`
- The variants in the enum `Metric` have been renumberd due to the
addition of
  line-to-line voltages.

Closes #135
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
part:❓ We need to figure out which part is affected priority:❓ We need to figure out how soon this should be addressed scope:breaking-change Breaking change, users will need to update their code type:enhancement New feature or enhancement visitble to users
Projects
None yet
Milestone
v0.6.0
Development

Successfully merging a pull request may close this issue.

Add line-to-line voltage metrics tiyash-basu-frequenz/frequenz-api-common
3 participants
@llucax @matthias-wende-frequenz @tiyash-basu-frequenz