Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use special label & visibility properties in panel settings example #111

Conversation

foxymiles
Copy link
Contributor

Public-Facing Changes

Use special label & visibility properties in the panel settings example to illustrate the use of these fields.

Description

Update the panel settings example to show panel authors how to take advantage of the label and visibility properties in settings editor nodes.

@foxymiles foxymiles marked this pull request as ready for review July 25, 2023 19:03
@defunctzombie
Copy link
Contributor

@foxymiles Does this fix the issue this user is experiencing: #112 Or is that unrelated?

It doesn't look like we have CI for our examples so maybe they are not working?

@foxymiles
Copy link
Contributor Author

Sounds like they copied over the ExamplePanel.tsx without also adding immer to their package.json.

@foxymiles foxymiles merged commit b5f6349 into main Jul 26, 2023
6 checks passed
@foxymiles foxymiles deleted the miles/fg-1103-document-behavior-of-label-edit-and-visibility-changes-in branch July 26, 2023 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants