-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Implement new link field #5373
feat: Implement new link field #5373
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/mn9rbh2yp |
return splitted[1] || splitted[0]; | ||
} | ||
|
||
@action |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codacy found an issue: Missing return type on function.
Here is an overview of what got changed by this pull request: Issues
======
- Added 3
Complexity increasing per file
==============================
- app/components/widgets/forms/link-field.ts 2
- tests/integration/components/widgets/forms/link-field-test.ts 1
See the complete overview on Codacy |
} | ||
|
||
@action | ||
setValue(event: any) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codacy found an issue: Argument 'event' should be typed with a non-any type.
return this.prefix + this.fixedValue; | ||
} | ||
|
||
get fixedValue() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codacy found an issue: Missing return type on function.
fdd3d90
to
4e0cf70
Compare
acd614e
to
aea2582
Compare
Codecov Report
@@ Coverage Diff @@
## development #5373 +/- ##
===============================================
+ Coverage 23.32% 23.69% +0.37%
===============================================
Files 494 497 +3
Lines 5226 5254 +28
Branches 39 44 +5
===============================================
+ Hits 1219 1245 +26
- Misses 4001 4003 +2
Partials 6 6
Continue to review full report at Codecov.
|
Nice!
|
Done |
Fixes #5116