Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor LinkInput to computed properties #4949

Closed
iamareebjamal opened this issue Sep 3, 2020 · 4 comments
Closed

Refactor LinkInput to computed properties #4949

iamareebjamal opened this issue Sep 3, 2020 · 4 comments
Labels
later refactor

Comments

@iamareebjamal
Copy link
Member

The component should be refactored to computed properties instead of observers in future

Originally posted by @iamareebjamal in #4947 (comment)
@iamareebjamal iamareebjamal added this to the Forms and Custom Forms milestone Sep 3, 2020
@jeetintyagi
Copy link

@iamareebjamal you mean '@computed' instead of @observes from '@ember/object'
correct me if i am wrong.

@iamareebjamal
Copy link
Member Author

Progress here - #5373

@jeetintyagi jeetintyagi mentioned this issue Oct 29, 2020
Closed
1 task
@skyRocket23
Copy link

.

@cweitat
Copy link
Contributor

cweitat commented Jul 7, 2023

Transitioning to vue so not needed

@cweitat cweitat closed this as not planned Won't fix, can't repro, duplicate, stale Jul 7, 2023
@mariobehling mariobehling removed this from the Wikimania M10 milestone Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
later refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fixes:#4949
5 participants
@mariobehling @iamareebjamal @cweitat @jeetintyagi @skyRocket23