Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checkout code before invoking whoan/docker-build-with-cache-action@v5 action #919

Merged
merged 1 commit into from
Apr 7, 2022

Conversation

eapolinario
Copy link
Collaborator

Signed-off-by: Eduardo Apolinario eapolinario@users.noreply.github.com

TL;DR

The build-and-push-docker-images job runs in a separate container, which requires to checkout the code before building the image.

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

#915 was not enough to build the docker images. Upon publishing v0.32.0b1 we were still seeing this error:

...
+ docker build --cache-from=ghcr.io/flyteorg/flytekit-stages:1 --tag my_awesome_image --file ./Dockerfile.py3.10 --compress=true --build-arg=VERSION= --build-arg=DOCKER_IMAGE=ghcr.io/flyteorg/flytekit:py3.10- .
+ tee build-output.log
unable to prepare context: unable to evaluate symlinks in Dockerfile path: lstat /github/workspace/Dockerfile.py3.10: no such file or directory
...

This indicates that the code is not present at the moment docker build is invoked, even though the file exists in the repo.

I'm also getting the version from the previous step as that dependency has to be expressed using the full path, in other words, instead of referring to the version using steps.bump.outputs.version we use deploy.steps.bump.outputs.version.

Tracking Issue

https://github.com/flyteorg/flyte/issues/

Follow-up issue

NA
OR
https://github.com/flyteorg/flyte/issues/

…5` action

Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
@eapolinario eapolinario merged commit 463ee78 into master Apr 7, 2022
myz540 pushed a commit to ProjectAussie/flytekit that referenced this pull request Apr 11, 2022
…5` action (flyteorg#919)

Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>

Co-authored-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
Signed-off-by: Mike Zhong <mzhong@embarkvet.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants