Fix dockerfiles #915
Merged
Fix dockerfiles #915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
eapolinario
force-pushed
the
fix-dockerfiles
branch
from
478e612
to
a976ffb
Compare
Codecov Report
@@ Coverage Diff @@
## master #915 +/- ##
=======================================
Coverage 86.43% 86.43%
=======================================
Files 243 243
Lines 23243 23243
Branches 2618 2618
=======================================
Hits 20089 20089
Misses 2713 2713
Partials 441 441 Continue to review full report at Codecov.
|
wild-endeavor
approved these changes
Apr 6, 2022
8 tasks
myz540
pushed a commit
to ProjectAussie/flytekit
that referenced
this pull request
Apr 11, 2022
* Change workdir to /root in dockerfiles Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> * Rename dockerfiles to match the versions used in CI Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> * Set python path to /root in dockerfiles Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> Co-authored-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> Signed-off-by: Mike Zhong <mzhong@embarkvet.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Fix docker images
Type
Are all requirements met?
Complete description
The name used by CI to find each python version corresponding python version was wrong (as it expected a file named "Dockerfile.pyVV" as opposed to "Dockerfile.pyV.V").
This PR also sets the workdir in the images to /root to be used in script mode.
Tracking Issue
flyteorg/flyte#2241
Follow-up issue
NA
OR
https://github.com/flyteorg/flyte/issues/