-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[various] Remove unused flutter_driver dependencies #4347
[various] Remove unused flutter_driver dependencies #4347
Conversation
Overrides: these are dev dependencies, so don't need to be versioned or mentioned in the changelog. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yikes, big offender on this one. Thanks for the cleanup! LGTM!
I think I'm the offender; IIRC I did a bunch of the switch of the driver files to |
flutter/packages@d4752c4...53ed5a0 2023-06-30 me@jxstxn.dev [google_maps_flutter_web] Add padding to newLatLngBounds implementation (flutter/packages#3452) 2023-06-29 stuartmorgan@google.com [various] Remove unused flutter_driver dependencies (flutter/packages#4347) 2023-06-29 stuartmorgan@google.com [ci] Add LUCI version of dart unit tests (flutter/packages#4265) 2023-06-29 49699333+dependabot[bot]@users.noreply.github.com [pigeon]: Bump org.jetbrains.kotlin:kotlin-gradle-plugin from 1.8.21 to 1.8.22 in /packages/pigeon/platform_tests/test_plugin/android (flutter/packages#4189) 2023-06-29 tarrinneal@gmail.com [shared_preferences] Adds new clearWithParameters and getAllWithParameters methods to all platforms. (flutter/packages#4262) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
flutter_driver
has been mostly replaced byintegration_test
, but we still have a lot of remaining dependencies on the package. This removes the dependency from pubspec.yaml for all plugins that aren't actuallyimport
ing it.It also removes an old video_player test that has been disabled for years that was never updated from flutter_driver to integration_test; we've since added a lot more testing to video_player, so in practice this is cruft that we can just remove.
Closes flutter/flutter#85224
Pre-launch Checklist
dart format
.)[shared_preferences]
pubspec.yaml
with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.md
to add a description of the change, following repository CHANGELOG style.///
).