Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] Add LUCI version of dart unit tests #4265

Merged
merged 2 commits into from
Jun 29, 2023

Conversation

stuartmorgan
Copy link
Contributor

Add initial LUCI versions of the dart unit tests task.

Part of flutter/flutter#114373

Add initial LUCI versions of the dart unit tests task.

Part of flutter/flutter#114373
@stuartmorgan
Copy link
Contributor Author

This takes noticeably longer than the Cirrus version using the "heavy workload" machine configuration, so I switched from two shards to three. Is that the preferred approach, or would it be better to make these use higher-spec config as well (presumably by increasing cores)?

@keyonghan
Copy link
Contributor

This takes noticeably longer than the Cirrus version using the "heavy workload" machine configuration, so I switched from two shards to three. Is that the preferred approach, or would it be better to make these use higher-spec config as well (presumably by increasing cores)?

With these targets as heavy workload, and have been running against more cpu/memory machines in cirrus, it makes sense to run them against higher-spec machines in LUCI, which are with 32-cores.

@stuartmorgan
Copy link
Contributor Author

Thanks, switched to two shards and 32-core machines, and we can see how that goes.

@stuartmorgan
Copy link
Contributor Author

@yusuf-goog Ping on this review?

@keyonghan
Copy link
Contributor

@yusuf-goog Ping on this review?

(Yusuf is ooo earlier this week, and not sure if he is back.)
LGTM with this PR, approving (sorry miss-tracked this after last week's comment..).

Copy link
Contributor

@keyonghan keyonghan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stuartmorgan stuartmorgan added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 29, 2023
@auto-submit auto-submit bot merged commit 9ec04ac into flutter:main Jun 29, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 30, 2023
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Jun 30, 2023
flutter/packages@d4752c4...53ed5a0

2023-06-30 me@jxstxn.dev [google_maps_flutter_web] Add padding to newLatLngBounds implementation (flutter/packages#3452)
2023-06-29 stuartmorgan@google.com [various] Remove unused flutter_driver dependencies (flutter/packages#4347)
2023-06-29 stuartmorgan@google.com [ci] Add LUCI version of dart unit tests (flutter/packages#4265)
2023-06-29 49699333+dependabot[bot]@users.noreply.github.com [pigeon]: Bump org.jetbrains.kotlin:kotlin-gradle-plugin from 1.8.21 to 1.8.22 in /packages/pigeon/platform_tests/test_plugin/android (flutter/packages#4189)
2023-06-29 tarrinneal@gmail.com [shared_preferences] Adds new clearWithParameters and getAllWithParameters methods to all platforms. (flutter/packages#4262)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants