Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Indexer FIP (ready to merge) #365

Closed
wants to merge 13 commits into from

Conversation

honghaoq
Copy link
Contributor

Updated latest version of Indexer FIP.

FIPS/IndexerFIP.md Outdated Show resolved Hide resolved
@anorth
Copy link
Member

anorth commented Apr 27, 2022

@kaitlin-beegle I'm not sure whether this should be a FIP or FRC. It doesn't propose any changes to the core Filecoin protocol, but proposes an ancillary protocol that is related and beneficial to Filecoin. But nodes don't have to implement it to remain fully-validating Filecoin nodes. It would still belong in this repo, but maybe have a different title. How shall we draw this distinction?

FIPS/IndexerFIP.md Outdated Show resolved Hide resolved
FIPS/IndexerFIP.md Outdated Show resolved Hide resolved
FIPS/IndexerFIP.md Show resolved Hide resolved
FIPS/IndexerFIP.md Outdated Show resolved Hide resolved
FIPS/IndexerFIP.md Outdated Show resolved Hide resolved
FIPS/IndexerFIP.md Outdated Show resolved Hide resolved
@kaitlin-beegle
Copy link
Collaborator

kaitlin-beegle commented Apr 27, 2022

@kaitlin-beegle I'm not sure whether this should be a FIP or FRC. It doesn't propose any changes to the core Filecoin protocol, but proposes an ancillary protocol that is related and beneficial to Filecoin. But nodes don't have to implement it to remain fully-validating Filecoin nodes. It would still belong in this repo, but maybe have a different title. How shall we draw this distinction?

Thanks for surfacing this. I was speaking with @honghaoq about this yesterday, and we briefly discussed it in Core Devs #41.

I think you're correct that this ought to remain in this repo, but should be separated from our standard/Core Technical FIPs. If accepted, this should be seen as a standard for implementations, but the actual implementation doesn't need to be as closely coordinated.

I'm inclined to adopt the EIP process, write up some quick documentation for this decision, open it for feedback for a few days, and codify this change (which seems a bit more formal) with a PR against FIP001. However, @anorth, I know you had previously suggested introducing an FRC format and decided that more thought was needed- are there any particular considerations or concerns that you currently have about this format?

Copy link

@irybakov irybakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, take this changes into account

FIPS/IndexerFIP.md Outdated Show resolved Hide resolved
FIPS/IndexerFIP.md Outdated Show resolved Hide resolved
FIPS/IndexerFIP.md Outdated Show resolved Hide resolved
@honghaoq honghaoq mentioned this pull request May 1, 2022
FIPS/IndexerFIP.md Outdated Show resolved Hide resolved
Copy link
Member

@anorth anorth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is ready to be merged as a draft.

FIPS/IndexerFIP.md Outdated Show resolved Hide resolved
Co-authored-by: Will <willscott@gmail.com>
@kaitlin-beegle
Copy link
Collaborator

@kaitlin-beegle I'm not sure whether this should be a FIP or FRC. It doesn't propose any changes to the core Filecoin protocol, but proposes an ancillary protocol that is related and beneficial to Filecoin. But nodes don't have to implement it to remain fully-validating Filecoin nodes. It would still belong in this repo, but maybe have a different title. How shall we draw this distinction?

Thanks for surfacing this. I was speaking with @honghaoq about this yesterday, and we briefly discussed it in Core Devs #41.

I think you're correct that this ought to remain in this repo, but should be separated from our standard/Core Technical FIPs. If accepted, this should be seen as a standard for implementations, but the actual implementation doesn't need to be as closely coordinated.

I'm inclined to adopt the EIP process, write up some quick documentation for this decision, open it for feedback for a few days, and codify this change (which seems a bit more formal) with a PR against FIP001. However, @anorth, I know you had previously suggested introducing an FRC format and decided that more thought was needed- are there any particular considerations or concerns that you currently have about this format?

Alright, just pushed new docs outlining a potential FRC process...once we come to agreement about the details of this process, I suggest that this be the network's first FRC!

To review: #378

CC: @anorth @honghaoq

FIPS/IndexerFIP.md Outdated Show resolved Hide resolved
Co-authored-by: Andrew Gillis <gammazero@users.noreply.github.com>
FIPS/IndexerFIP.md Outdated Show resolved Hide resolved
FIPS/IndexerFIP.md Outdated Show resolved Hide resolved
@honghaoq honghaoq closed this Jun 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants