Softsign optimization #585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me. Would be nice to add a test, just to show correct behaviour. We could do it in a similar way to other activations, in |
Added one test file. |
vloncar
reviewed
Jul 25, 2022
test/pytest/test_softsign.py
Outdated
|
|
||
| print('Accuracy hls4ml relative to keras: {}'.format(acc_hls4ml)) | ||
|
|
||
| assert acc_hls4ml >= 0.7 |
There was a problem hiding this comment.
Changed to 0.98. New tests have also been added to the pytest file.
vloncar
approved these changes
Sep 14, 2022
7 tasks
vloncar
added a commit
that referenced
this pull request
Sep 20, 2022
Quartus Streaming Softsign (PR #585 contd.)
7 tasks
calad0i
pushed a commit
to calad0i/hls4ml
that referenced
this pull request
Jul 1, 2023
* Softsign LUT optimization * Test file: Activation softsign * Changing minimal accurancy to 9.8 and adding new texts using Vivado and Quartus Co-authored-by: Nemer Chiedde <chiedde@marchied.in2p3.fr>
calad0i
pushed a commit
to calad0i/hls4ml
that referenced
this pull request
Jul 1, 2023
Quartus Streaming Softsign (PR fastmachinelearning#585 contd.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Storing only the positive part of the Softsign is possible due to its symmetry in the Y axis. Same theory when presented in pull request: #527