Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimized look-up table #527

Merged
merged 5 commits into from
Apr 25, 2022
Merged

Optimized look-up table #527

merged 5 commits into from
Apr 25, 2022

Conversation

nemerchiedde
Copy link
Contributor

This pull request adds the new optimized LUT, as presented in https://indico.cern.ch/event/1145909/

vloncar
vloncar requested changes Apr 21, 2022
View reviewed changes
Copy link
Contributor

@vloncar vloncar left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Nemer, this is really nice. Can you address the comments below?
Also, can you switch to using 4 spaces as indentation in the HLS code? Right now, you mix 2 and 4 spaces. It would help with readability.

hls4ml/writer/quartus_writer.py Outdated Show resolved Hide resolved
hls4ml/writer/quartus_writer.py Outdated Show resolved Hide resolved
hls4ml/writer/quartus_writer.py Outdated Show resolved Hide resolved
@vloncar vloncar merged commit 7c7b7af into fastmachinelearning:master Apr 25, 2022
This was referenced Jun 27, 2022
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vloncar vloncar vloncar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nemerchiedde @vloncar @bo3z