Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Visual fixes for button migration issues #5363

Merged
merged 1 commit into from
Oct 9, 2024
Merged

Visual fixes for button migration issues #5363

merged 1 commit into from
Oct 9, 2024

Conversation

jpople
Copy link
Contributor

@jpople jpople commented Oct 8, 2024

Closes

Description Of Changes

Fixes a couple of small visual issues that arose as part of #5357.

Before:
image

After:
Screenshot 2024-10-08 at 16 45 17

Before:
image

After:
Screenshot 2024-10-08 at 16 47 00

@vercel Vercel
Copy link

vercel bot commented Oct 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fides-plus-nightly ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 8, 2024 11:48pm

erosselli
erosselli approved these changes Oct 8, 2024
View reviewed changes
Copy link
Contributor

@erosselli erosselli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making such a quick fix! 🚀 ⚡

@cypress Cypress
Copy link

cypress bot commented Oct 9, 2024

fides    Run #10364

Run Properties:  status check passed Passed #10364  •  git commit 33e4aba5f2 ℹ️: Merge 005d86fa6dcc318ed0f63ce87105736305d1f6fd into c294fb532a23645f7d237b50f27d...
Project fides
Run status status check passed Passed #10364
Run duration 00m 38s
Commit git commit 33e4aba5f2 ℹ️: Merge 005d86fa6dcc318ed0f63ce87105736305d1f6fd into c294fb532a23645f7d237b50f27d...
Committer jpople
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

@jpople jpople merged commit 3699023 into main Oct 9, 2024
13 checks passed
@jpople jpople deleted the jpople/button-migration-visual-fixes branch October 9, 2024 16:20
@cypress Cypress
Copy link

cypress bot commented Oct 9, 2024

fides    Run #10368

Run Properties:  status check passed Passed #10368  •  git commit 36990231d4: Visual fixes for button migration issues (#5363)
Project fides
Run status status check passed Passed #10368
Run duration 00m 38s
Commit git commit 36990231d4: Visual fixes for button migration issues (#5363)
Committer jpople
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erosselli erosselli erosselli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jpople @erosselli