Visual fixes for button migration issues (#5363)

ethyca · Oct 9, 2024 · 3699023 · 3699023
1 parent 86bb3f7
commit 3699023
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 19 deletions.
diff --git a/...min-ui/src/features/datastore-connections/system_portal_config/ConnectionListDropdown.tsx b/...min-ui/src/features/datastore-connections/system_portal_config/ConnectionListDropdown.tsx
@@ -3,7 +3,6 @@ import {
   AntButton as Button,
   ArrowDownLineIcon,
   Box,
-  ButtonProps,
   Flex,
   Input,
   InputGroup,
@@ -69,10 +68,6 @@ type SelectDropdownProps = {
    * Disable the control
    */
   disabled?: boolean;
-  /**
-   * Menu button props
-   */
-  menuButtonProps?: ButtonProps;
 };
 
 type UseConnectionListDropDown = {
@@ -139,7 +134,6 @@ const ConnectionListDropdown = ({
   hasClear = true,
   label,
   list,
-  menuButtonProps,
   onChange,
   selectedValue,
 }: SelectDropdownProps) => {
@@ -199,19 +193,12 @@ const ConnectionListDropdown = ({
     >
       <MenuButton
         aria-label={selectedText ?? label}
+        as={Button}
         color={selectedText ? "complimentary.500" : undefined}
         disabled={disabled}
-        fontWeight="normal"
-        rightIcon={<ArrowDownLineIcon />}
-        size="sm"
-        variant="outline"
-        _active={{
-          bg: "none",
-        }}
-        _hover={{
-          bg: "none",
-        }}
-        {...menuButtonProps}
+        icon={<ArrowDownLineIcon />}
+        iconPosition="end"
+        className="!bg-transparent hover:bg-transparent active:bg-transparent"
         data-testid="select-dropdown-btn"
         width="272px"
         textAlign="left"

diff --git a/...src/features/datastore-connections/system_portal_config/forms/ConnectorParametersForm.tsx b/...src/features/datastore-connections/system_portal_config/forms/ConnectorParametersForm.tsx
@@ -345,7 +345,7 @@ export const ConnectorParametersForm = ({
         return (
           <Form noValidate>
             <VStack align="stretch" gap="16px">
-              <div>
+              <div className="flex flex-row">
                 {connectionConfig ? (
                   <DisableConnectionModal
                     connection_key={connectionConfig?.key}

diff --git a/clients/admin-ui/src/features/taxonomy/TaxonomyFormBase.tsx b/clients/admin-ui/src/features/taxonomy/TaxonomyFormBase.tsx
@@ -131,7 +131,7 @@ const TaxonomyFormBase = ({
               </Text>
             ) : null}
 
-            <div>
+            <div className="flex gap-4">
               <Button data-testid="cancel-btn" onClick={onCancel}>
                 Cancel
               </Button>